Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Cr108 Follow up] Removed hiding of link on Passwords page. #15980

Merged
merged 1 commit into from
Nov 16, 2022

Conversation

mkarolin
Copy link
Collaborator

@mkarolin mkarolin commented Nov 16, 2022

Resolves #15980

The link no longer exists so we don't need to hide it.

Chromium change:

https://chromium.googlesource.com/chromium/src/+/0ec0534fe2b9c66e69f5fb2750a57dc9eec65e08

commit 0ec0534fe2b9c66e69f5fb2750a57dc9eec65e08
Author: Mohamed Amir Yosef mamir@chromium.org
Date: Fri Aug 19 12:58:58 2022 +0000

[Passwords] Clean up UPM from Setting UI

In addition, this CL remove all obsolete resources (images and strings)

Bug: 1310270

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

The link no longer exists so we don't need to hide it.

Chromium change:

https://chromium.googlesource.com/chromium/src/+/0ec0534fe2b9c66e69f5fb2750a57dc9eec65e08

commit 0ec0534fe2b9c66e69f5fb2750a57dc9eec65e08
Author: Mohamed Amir Yosef <mamir@chromium.org>
Date:   Fri Aug 19 12:58:58 2022 +0000

    [Passwords] Clean up UPM from Setting UI

    In addition, this CL remove all obsolete resources (images and strings)

    Bug: 1310270
@mkarolin mkarolin self-assigned this Nov 16, 2022
@github-actions github-actions bot added the CI/storybook-url Deploy storybook and provide a unique URL for each build label Nov 16, 2022
Copy link
Contributor

@emerick emerick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@LaurenWags
Copy link
Member

LaurenWags commented Nov 18, 2022

Verified with

Brave | 1.47.84 Chromium: 108.0.5359.48 (Official Build) nightly (x86_64)
-- | --
Revision | 18ceeca0d99318e70c00d2e04d88aa55488b5c63-refs/branch-heads/5359@{#854}
OS | macOS Version 12.6.1 (Build 21G217)

Verified test plan from brave/brave-browser#26821 (comment):

  • Verify that Settings -> Autofill -> Passwords Manager page doesn't show any unexpected UI elements and there's no error in the DevTools console

Compared UI on 1.45.127 (current release) and 1.47.84 (latest Nightly), confirmed UI looks the same.
Confirmed no errors in DevTools console (confirmed warnings are ok).

1.45.127 1.47.84 1.47.84
1 45 127 1 47 84 3

mkarolin added a commit that referenced this pull request Nov 18, 2022
[Cr108 Follow up] Removed hiding of link on Passwords page.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/storybook-url Deploy storybook and provide a unique URL for each build
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants