Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Cr108 Follow up] Setting console error "Could not find manageLink in passwords_section" #26821

Closed
mkarolin opened this issue Nov 16, 2022 · 2 comments
Closed

[Cr108 Follow up] Setting console error "Could not find manageLink in passwords_section" #26821

mkarolin opened this issue Nov 16, 2022 · 2 comments
Assignees
@mkarolin
Labels
OS/Desktop QA Pass-Win64 QA/Test-Plan-Specified QA/Yes release-notes/exclude
Milestone
1.46.x - Release

Comments

@mkarolin
Copy link
Contributor

The section we were hiding (since Chromium 87) is no longer on the passwords settings page (removed in Chromium 107).
We can now remove the code trying to hide it.

QA Testing:

  • Please verify that Settings -> Autofill -> Passwords Manager page doesn't show any unexpected UI elements and there's no error in the DevTools console.
@mkarolin mkarolin self-assigned this Nov 16, 2022
@mkarolin mkarolin mentioned this issue Nov 16, 2022
Merged
25 tasks
@mkarolin mkarolin added this to the 1.47.x - Nightly milestone Nov 16, 2022
@mkarolin mkarolin mentioned this issue Nov 16, 2022
Merged
25 tasks
@mkarolin
Copy link
Contributor Author

Resolved via brave/brave-core#15980

@LaurenWags LaurenWags mentioned this issue Nov 18, 2022
Merged
25 tasks
@MadhaviSeelam
Copy link

Verification PASSED using

Brave | 1.46.123 Chromium: 108.0.5359.48 (Official Build) beta (64-bit)
-- | --
Revision | 18ceeca0d99318e70c00d2e04d88aa55488b5c63-refs/branch-heads/5359@{#854}
OS | Windows 11 Version 21H2 (Build 22000.1219)
  1. Install 1.46.123
  2. launch brave
  3. opened brave://settings/passwords

Confirmed Passwords Manger page do not show any unexpected UI elements and the UI matches with 1.45.131 (current release)

Confirmed no errors shown in DevTools console

1.46.123 1.45.131
image image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mkarolin mkarolin

Labels
OS/Desktop QA Pass-Win64 QA/Test-Plan-Specified QA/Yes release-notes/exclude
Projects
None yet
Milestone
1.46.x - Release
Development

No branches or pull requests
3 participants
@mkarolin @brave-builds @MadhaviSeelam