Fixed 'Request bridge' in settings. #14914
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iefremov
approved these changes
Aug 31, 2022
|
Reproduced the original issue on Went through the STR/Cases outlined via brave/brave-browser#25095 (comment) and reproduced the original issue as per the following:
Verification PASSED on Went through the STR/Cases outlined via brave/brave-browser#25095 (comment) and went through the following:
|
| @@ -82,7 +82,8 @@ constexpr const char16_t kParseBridgesScript[] = | |||
| if (!bridgeLines) return null | |||
|
|
|||
| const bridges = bridgeLines.textContent.split('\n').filter( | |||
| (bridge) => { return bridge.trim().length != 0 }) | |||
| (bridge) => { return bridge.trim().length != 0 }). | |||
| map((brigde) => { return brigde.trim(); }) | |||
There was a problem hiding this comment.
@boocmp s/brigde/bridge, right?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves brave/brave-browser#25095
Submitter Checklist:
QA/YesorQA/No;release-notes/includeorrelease-notes/exclude;OS/...) to the associated issuenpm run test -- brave_browser_tests,npm run test -- brave_unit_tests,npm run lint,npm run gn_check,npm run tslintgit rebase master(if needed)Reviewer Checklist:
gnAfter-merge Checklist:
changes has landed on
Test Plan:
brave/brave-browser#25095 (comment) & #14914 (comment).