Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade from Chromium 105 to Chromium 106 #14529

Merged
merged 124 commits into from
Sep 16, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
124 commits
Select commit Hold shift + click to select a range
0905752
Update from Chromium 105.0.5195.19 to Chromium 106.0.5216.6
cdesouza-chromium Aug 8, 2022
89ca98f
Conflict-resolved patches from Chromium 105.0.5195.19 to Chromium 106…
cdesouza-chromium Aug 8, 2022
4499c3b
Updated patches from Chromium 105.0.5195.19 to Chromium 106.0.5216.6.
cdesouza-chromium Aug 8, 2022
dc1e648
Web time limits strings removed
cdesouza-chromium Aug 8, 2022
6a2d475
Updated strings for Chromium 106.0.5216.6.
cdesouza-chromium Aug 8, 2022
44a5c01
Revert "Disable ThinLTO config moved gn files"
cdesouza-chromium Aug 8, 2022
27145d2
Cookie queries now require a query reason
cdesouza-chromium Aug 8, 2022
d3c9c98
[Android] SiteSettings: Replace showSites() with getType()
samartnik Aug 8, 2022
531948e
[WIP] [Android] DynamicColors features removed
samartnik Aug 8, 2022
133a673
Omnibox background colours renamed
cdesouza-chromium Aug 9, 2022
803aa6b
base::Value::ListStorage not public anymore
cdesouza-chromium Aug 9, 2022
8a4d3f9
Removed DictionaryValueUpdate::GetList
cdesouza-chromium Aug 9, 2022
8f945be
TabContainer refactored upstream
cdesouza-chromium Aug 9, 2022
c898792
Unsafe narrowing conversion fixes for Sidebar items
cdesouza-chromium Aug 10, 2022
74c28d8
[Android] Fix for lint warning
samartnik Aug 9, 2022
ddf4cb1
[Android] DynamicColors features removed
samartnik Aug 9, 2022
001312d
Add TabCloseTypes enum
cdesouza-chromium Aug 10, 2022
17bcead
WebFeature::kClientHintsMetaNameAcceptCH deleted
cdesouza-chromium Aug 10, 2022
ef43316
ProfileMenuViewBase methods moved to a coordinator
cdesouza-chromium Aug 10, 2022
1ef3b8d
net::SignatureAlgorithm changed into a enum
cdesouza-chromium Aug 11, 2022
0d20dcc
Changes to HistoryAddPageArgs constructor
cdesouza-chromium Aug 11, 2022
7f8f9b8
Update from Chromium 106.0.5216.6 to Chromium 106.0.5228.2
cdesouza-chromium Aug 11, 2022
88f68a0
Conflict-resolved patches from Chromium 106.0.5216.6 to Chromium 106.…
cdesouza-chromium Aug 11, 2022
3674527
Updated patches from Chromium 106.0.5216.6 to Chromium 106.0.5228.2.
cdesouza-chromium Aug 11, 2022
46c87ed
Updated strings for Chromium 106.0.5228.2.
cdesouza-chromium Aug 11, 2022
2c0fee6
Further restructuring to resource/settings/BUILD.gn
cdesouza-chromium Aug 11, 2022
703d33a
fixup! Further restructuring to resource/settings/BUILD.gn
cdesouza-chromium Sep 14, 2022
a61d2df
Content settings scope reworked upstream
cdesouza-chromium Aug 11, 2022
7a6f634
Type deduction disallowed when adding associated interfaces
cdesouza-chromium Aug 11, 2022
566afeb
Override update for TrimAndPersistUnsentLogs
cdesouza-chromium Aug 11, 2022
e199d5b
Constructor update for BookmarkContextMenuController
cdesouza-chromium Aug 12, 2022
4ac5ec2
[Android] Fix for Android build
samartnik Aug 11, 2022
7b8364d
[Android] Reverted size_t back to int
samartnik Aug 11, 2022
05ab8b6
[Android] New c-tor signature for TopToolbarCoordinator
samartnik Aug 11, 2022
21c610c
[Android] New method for DropdownItemProcessor
samartnik Aug 11, 2022
2a70313
Import cr_icon_button.js not cr_icon_button.m.js
emerick Aug 12, 2022
1751fd9
Update signature for GetVariationsList
emerick Aug 12, 2022
618e162
Update from Chromium 106.0.5228.2 to Chromium 106.0.5231.2
cdesouza-chromium Aug 13, 2022
0aa6299
Conflict-resolved patches from Chromium 106.0.5228.2 to Chromium 106.…
cdesouza-chromium Aug 13, 2022
6b42699
Updated patches from Chromium 106.0.5228.2 to Chromium 106.0.5231.2.
cdesouza-chromium Aug 13, 2022
4aa0fde
Updated strings for Chromium 106.0.5231.2.
cdesouza-chromium Aug 13, 2022
f85431b
File version.gni moved into chrome/
cdesouza-chromium Aug 13, 2022
03e43f5
GetMimeType taking a URL as argument
cdesouza-chromium Aug 14, 2022
8ad06eb
BookmarkLaunchLocation enum created
cdesouza-chromium Aug 14, 2022
a77fa97
ApplicationContextImpl::GetPromosManager implementation
cdesouza-chromium Aug 15, 2022
5aa0e71
Push notications service added ApplicationContextImpl
cdesouza-chromium Aug 23, 2022
763a191
Added GetAsSyncServiceImplForBrowserStateForTesting
cdesouza-chromium Aug 15, 2022
1d2d410
New ios chromium follow provider
cdesouza-chromium Aug 15, 2022
8f83a59
Disable chrashing chromium unit tests
cdesouza-chromium Aug 16, 2022
9f9cd7f
Prefetching headers moved into preloading
cdesouza-chromium Aug 17, 2022
bcfcde4
kIsolatePrerenders was moved
samartnik Aug 17, 2022
a438a94
Update from Chromium 106.0.5231.2 to Chromium 106.0.5243.2
cdesouza-chromium Aug 18, 2022
2941d95
Conflict-resolved patches from Chromium 106.0.5231.2 to Chromium 106.…
cdesouza-chromium Aug 18, 2022
5a4ec40
Updated patches from Chromium 106.0.5231.2 to Chromium 106.0.5243.2.
cdesouza-chromium Aug 18, 2022
580003f
Updated strings for Chromium 106.0.5243.2.
cdesouza-chromium Aug 18, 2022
1add29f
AccessibilityChecker simplified in implementation
cdesouza-chromium Aug 18, 2022
d684441
Use //components/sync:test_support
cdesouza-chromium Aug 18, 2022
bdc376d
Changes to CookieSettingsBase constructor
cdesouza-chromium Aug 18, 2022
69f0702
blink::Color RGBA32 constructor removed
cdesouza-chromium Aug 18, 2022
a8a5c57
Update from Chromium 106.0.5243.2 to Chromium 106.0.5245.0
cdesouza-chromium Aug 18, 2022
11b7f4f
Conflict-resolved patches from Chromium 106.0.5243.2 to Chromium 106.…
cdesouza-chromium Aug 18, 2022
9e9fd44
Updated patches from Chromium 106.0.5243.2 to Chromium 106.0.5245.0.
cdesouza-chromium Aug 18, 2022
7d09494
Updated strings for Chromium 106.0.5245.0.
cdesouza-chromium Aug 18, 2022
9638e4f
HistoryServiceObserver::OnURLVisited changed signature
cdesouza-chromium Aug 18, 2022
1088798
RegisterWebUIControllerInterfaceBinder moved into //content
cdesouza-chromium Aug 19, 2022
afe6ab2
PermissionManager refactor
cdesouza-chromium Aug 19, 2022
7374506
Migration to ProfileKeyedServiceFactory
cdesouza-chromium Aug 19, 2022
5143aa5
Changes to first run dialog
cdesouza-chromium Aug 19, 2022
dedc4fd
SkAlpha initialisation tightened by narrowing fixes
cdesouza-chromium Aug 19, 2022
516d8ae
Sync test files moved components/sync/test/
cdesouza-chromium Aug 19, 2022
056668e
base::Value refactoring in PeopleHandler
cdesouza-chromium Aug 23, 2022
5886359
base::Value refactorign on sync internals
cdesouza-chromium Aug 23, 2022
766248c
Rename cr_dialog.m.js import to cr_dialog.js
emerick Aug 22, 2022
66803bb
Adjusting BraveSidePanel to upstream expectations
cdesouza-chromium Aug 23, 2022
3e924fb
Update from Chromium 106.0.5245.0 to Chromium 106.0.5249.12
cdesouza-chromium Aug 26, 2022
d3a7224
Conflict-resolved patches from Chromium 106.0.5245.0 to Chromium 106.…
cdesouza-chromium Aug 26, 2022
3e79538
Updated patches from Chromium 106.0.5245.0 to Chromium 106.0.5249.12.
cdesouza-chromium Aug 26, 2022
baf9e11
Updated strings for Chromium 106.0.5249.12.
cdesouza-chromium Aug 26, 2022
dc273d1
NTP task module files renamed as recipe
cdesouza-chromium Aug 26, 2022
91bcedf
Text styles consolidated into views::style::TextStyle
cdesouza-chromium Aug 26, 2022
16e8754
Follow up for PermissionManager refactor.
goodov Aug 26, 2022
6097457
[Android] Usage of ManageAccountDevicesLinkView was changed
samartnik Aug 26, 2022
b4d36d8
Rename cr_button import from cr_button.m.js to cr_button.js
emerick Aug 28, 2022
8799d7a
Rename cr_input import from cr_input.m.js to cr_input.js
emerick Aug 28, 2022
075358a
Ignoring certificate errors on Binance/Gemini test
emerick Aug 29, 2022
cf2aded
Private aggregation feature flags moved into //content/common
emerick Aug 29, 2022
9c52db9
Remove no longer needed GetVersionNumber redefinition
emerick Aug 29, 2022
82d2770
Remove pragma clang max_tokens_here overrides since experiment is now…
emerick Aug 29, 2022
a14d951
[Android] Fix for unit tests
samartnik Aug 30, 2022
41ed1d8
Update from Chromium 106.0.5249.12 to Chromium 106.0.5249.19
cdesouza-chromium Aug 31, 2022
a8c76aa
Conflict-resolved patches from Chromium 106.0.5249.12 to Chromium 106…
cdesouza-chromium Aug 31, 2022
586bae0
Updated patches from Chromium 106.0.5249.12 to Chromium 106.0.5249.19.
cdesouza-chromium Aug 31, 2022
a3127e6
BookmarkModelFactory/ManagedBookmarkServiceFactory browser context fixes
cdesouza-chromium Aug 31, 2022
fd42dd4
[Android] Fixes for top and bottom toolbar coordinators
samartnik Aug 31, 2022
8bc2096
[Android] Fix for proguard error
samartnik Sep 1, 2022
e6abc24
Update from Chromium 106.0.5249.19 to Chromium 106.0.5249.21
cdesouza-chromium Sep 1, 2022
d7aa253
Conflict-resolved patches from Chromium 106.0.5249.19 to Chromium 106…
cdesouza-chromium Sep 1, 2022
4f1c6e5
Updated patches from Chromium 106.0.5249.19 to Chromium 106.0.5249.21.
cdesouza-chromium Sep 1, 2022
f808ee2
Updated strings for Chromium 106.0.5249.21.
cdesouza-chromium Sep 1, 2022
6105df9
Added arguments to GetWindowFeaturesFromString
cdesouza-chromium Aug 19, 2022
c0ee57e
Make adjustments for upstream unit tests
emerick Sep 2, 2022
4547eb3
Make adjustments for upstream browser tests
emerick Sep 2, 2022
2a6aec5
Update from Chromium 106.0.5249.21 to Chromium 106.0.5249.23
cdesouza-chromium Sep 5, 2022
75227ac
Conflict-resolved patches from Chromium 106.0.5249.21 to Chromium 106…
cdesouza-chromium Sep 5, 2022
39c08a1
Updated patches from Chromium 106.0.5249.21 to Chromium 106.0.5249.23.
cdesouza-chromium Sep 5, 2022
4b663ab
Disable tests regarding languages fingerprint
cdesouza-chromium Sep 7, 2022
ac21639
Disable comfirm close dialog on upstream tests
cdesouza-chromium Sep 7, 2022
4d73487
LZMA executable moved on Windows and also use Mac executable
emerick Sep 7, 2022
c8a56ab
Update from Chromium 106.0.5249.23 to Chromium 106.0.5249.31
cdesouza-chromium Sep 8, 2022
7f34567
Conflict-resolved patches from Chromium 106.0.5249.23 to Chromium 106…
cdesouza-chromium Sep 8, 2022
f165ff0
Updated patches from Chromium 106.0.5249.23 to Chromium 106.0.5249.31.
cdesouza-chromium Sep 8, 2022
a07bbe4
Disable Chromium features flagged by security/privacy teams
emerick Sep 10, 2022
1aaa71f
Fixing inclusion of drop down js file for Wallet webui
cdesouza-chromium Sep 13, 2022
d15468f
Remove obsolete patch and override (underlying issue was addressed up…
emerick Sep 13, 2022
2507f06
Removing patch for BraveBrowserDataRemoverDelegage
cdesouza-chromium Sep 14, 2022
3afc882
Removing content_settings_types.h patch
cdesouza-chromium Sep 14, 2022
9e64f1b
Removing patch extension HistogramValue
cdesouza-chromium Sep 14, 2022
6be0091
Update from Chromium 106.0.5249.31 to Chromium 106.0.5249.38
cdesouza-chromium Sep 14, 2022
5227480
Conflict-resolved patches from Chromium 106.0.5249.31 to Chromium 106…
cdesouza-chromium Sep 14, 2022
c076f92
Updated patches from Chromium 106.0.5249.31 to Chromium 106.0.5249.38.
cdesouza-chromium Sep 14, 2022
bbcd14b
base::Feature cannot be foward-declared anymore
cdesouza-chromium Sep 2, 2022
947d01f
Update from Chromium 106.0.5249.38 to Chromium 106.0.5249.40
cdesouza-chromium Sep 14, 2022
47286a0
Conflict-resolved patches from Chromium 106.0.5249.38 to Chromium 106…
cdesouza-chromium Sep 14, 2022
b5ef267
Updated patches from Chromium 106.0.5249.38 to Chromium 106.0.5249.40.
cdesouza-chromium Sep 14, 2022
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
6 changes: 5 additions & 1 deletion BUILD.gn
Original file line number Diff line number Diff line change
Expand Up @@ -5,12 +5,16 @@ import("//build/config/locales.gni")
import("//build/config/zip.gni")
import("//build/util/process_version.gni")
import("//extensions/buildflags/buildflags.gni")
import("//media/cdm/library_cdm/cdm_paths.gni")
import("//media/media_options.gni")
import("//third_party/icu/config.gni")
import("//tools/grit/repack.gni")
import("//tools/v8_context_snapshot/v8_context_snapshot.gni")
import("//ui/base/ui_features.gni")

if (enable_library_cdms) {
import("//media/cdm/library_cdm/cdm_paths.gni")
}

if (!is_ios) {
import("//brave/brave_paks.gni")
}
Expand Down
1 change: 1 addition & 0 deletions android/brave_java_sources.gni
Original file line number Diff line number Diff line change
Expand Up @@ -346,6 +346,7 @@ brave_java_sources = [
"../../brave/android/java/org/chromium/chrome/browser/upgrade/NotificationIntent.java",
"../../brave/android/java/org/chromium/chrome/browser/util/BraveConstants.java",
"../../brave/android/java/org/chromium/chrome/browser/util/BraveDbUtil.java",
"../../brave/android/java/org/chromium/chrome/browser/util/BraveDynamicColors.java",
"../../brave/android/java/org/chromium/chrome/browser/util/ConfigurationUtils.java",
"../../brave/android/java/org/chromium/chrome/browser/util/ImageUtils.java",
"../../brave/android/java/org/chromium/chrome/browser/util/LiveDataUtil.java",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@
import androidx.annotation.NonNull;

import org.chromium.base.ApiCompatibilityUtils;
import org.chromium.base.Callback;
import org.chromium.base.supplier.ObservableSupplier;
import org.chromium.base.supplier.OneshotSupplier;
import org.chromium.base.supplier.Supplier;
Expand Down Expand Up @@ -85,8 +86,9 @@ public BraveTabGroupUiCoordinator(@NonNull Activity activity, @NonNull ViewGroup

@Override
public void initializeWithNative(Activity activity,
BottomControlsCoordinator.BottomControlsVisibilityController visibilityController) {
super.initializeWithNative(activity, visibilityController);
BottomControlsCoordinator.BottomControlsVisibilityController visibilityController,
Callback<Object> onModelTokenChange) {
super.initializeWithNative(activity, visibilityController, onModelTokenChange);

mIncognitoStateObserver = (isIncognito) -> {
if (!isIncognito) {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -1610,12 +1610,6 @@ public void initializeCompositor() {
ContextUtils.getApplicationContext());
}

@Override
protected boolean supportsDynamicColors() {
// Dynamic colors cause styling issues with Brave theme.
return false;
}

private void InitBraveWalletService() {
if (mBraveWalletService != null) {
return;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -96,6 +96,9 @@ public BraveEthereumPermissionPromptDialog(long nativeDialogController,
}
}

// TODO: It is much more efficient to retrieve resources by identifier (e.g. R.foo.bar) than by
// name (e.g. getIdentifier("bar", "foo", null)).
@SuppressLint("DiscouragedApi")
@CalledByNative
void show() {
View customView = LayoutInflaterUtils.inflate(
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -38,10 +38,4 @@ public boolean onOptionsItemSelected(MenuItem item) {
}
return super.onOptionsItemSelected(item);
}

@Override
protected boolean supportsDynamicColors() {
// Dynamic colors cause styling issues with Brave theme.
return false;
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -236,7 +236,7 @@ public void enableBottomControls() {
mActivity, mWindowAndroid, mLayoutManager,
mCompositorViewHolder.getResourceManager(), mBrowserControlsSizer,
mFullscreenManager, mBottomControls, mTabGroupUi,
mOverlayPanelVisibilitySupplier));
mOverlayPanelVisibilitySupplier, getConstraintsProxy()));
mBottomControls.setBottomControlsCoordinatorSupplier(
mBottomControlsCoordinatorSupplier);
updateBottomToolbarVisibility();
Expand Down Expand Up @@ -345,4 +345,13 @@ private boolean isToolbarPhone() {
return mToolbar instanceof BraveTopToolbarCoordinator
&& ((BraveTopToolbarCoordinator) mToolbar).isToolbarPhone();
}

private ObservableSupplier<Integer> getConstraintsProxy() {
if (mToolbar instanceof BraveTopToolbarCoordinator) {
return ((BraveTopToolbarCoordinator) mToolbar).getConstraintsProxy();
}

assert false : "Wrong top toolbar type!";
return null;
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -62,9 +62,11 @@ public BraveBottomControlsCoordinator(
ResourceManager resourceManager, BrowserControlsSizer controlsSizer,
FullscreenManager fullscreenManager, ScrollingBottomViewResourceFrameLayout root,
BottomControlsContentDelegate contentDelegate,
ObservableSupplier<Boolean> overlayPanelVisibilitySupplier) {
ObservableSupplier<Boolean> overlayPanelVisibilitySupplier,
ObservableSupplier<Integer> constraintsSupplier) {
super(activity, windowAndroid, layoutManager, resourceManager, controlsSizer,
fullscreenManager, root, contentDelegate, overlayPanelVisibilitySupplier);
fullscreenManager, root, contentDelegate, overlayPanelVisibilitySupplier,
constraintsSupplier);

mTabSwitcherLongclickListener = tabSwitcherLongclickListener;
mTabProvider = tabProvider;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,7 @@ public class BraveTopToolbarCoordinator extends TopToolbarCoordinator {
private ToolbarLayout mBraveToolbarLayout;
private MenuButtonCoordinator mBraveMenuButtonCoordinator;
private boolean mIsBottomToolbarVisible;
private ObservableSupplier<Integer> mConstraintsProxy;

public BraveTopToolbarCoordinator(ToolbarControlContainer controlContainer,
ViewStub toolbarStub, ViewStub fullscreenToolbarStub, ToolbarLayout toolbarLayout,
Expand All @@ -65,7 +66,9 @@ public BraveTopToolbarCoordinator(ToolbarControlContainer controlContainer,
HistoryDelegate historyDelegate, BooleanSupplier partnerHomepageEnabledSupplier,
OfflineDownloader offlineDownloader, boolean initializeWithIncognitoColors,
ObservableSupplier<Profile> profileSupplier,
Callback<LoadUrlParams> startSurfaceLogoClickedCallback) {
Callback<LoadUrlParams> startSurfaceLogoClickedCallback,
boolean isStartSurfaceRefactorEnabled,
ObservableSupplier<Integer> constraintsSupplier) {
super(controlContainer, toolbarStub, fullscreenToolbarStub, toolbarLayout,
toolbarDataProvider, tabController, userEducationHelper, buttonDataProviders,
layoutStateProviderSupplier, normalThemeColorProvider, overviewThemeColorProvider,
Expand All @@ -77,10 +80,12 @@ public BraveTopToolbarCoordinator(ToolbarControlContainer controlContainer,
isTabToGtsAnimationEnabled, isStartSurfaceEnabled,
isTabGroupsAndroidContinuationEnabled, historyDelegate,
partnerHomepageEnabledSupplier, offlineDownloader, initializeWithIncognitoColors,
profileSupplier, startSurfaceLogoClickedCallback);
profileSupplier, startSurfaceLogoClickedCallback, isStartSurfaceRefactorEnabled,
constraintsSupplier);

mBraveToolbarLayout = toolbarLayout;
mBraveMenuButtonCoordinator = browsingModeMenuButtonCoordinator;
mConstraintsProxy = constraintsSupplier;

if (isToolbarPhone()) {
if (!isStartSurfaceEnabled) {
Expand Down Expand Up @@ -115,4 +120,8 @@ public MenuButton getMenuButtonWrapper() {
// We consider that there is no top toolbar menu button, if bottom toolbar is visible.
return mIsBottomToolbarVisible ? null : mBraveMenuButtonCoordinator.getMenuButton();
}

public ObservableSupplier<Integer> getConstraintsProxy() {
return mConstraintsProxy;
}
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
/* Copyright (c) 2022 The Brave Authors. All rights reserved.
* This Source Code Form is subject to the terms of the Mozilla Public
* License, v. 2.0. If a copy of the MPL was not distributed with this file,
* You can obtain one at http://mozilla.org/MPL/2.0/. */

package org.chromium.chrome.browser.util;

import android.app.Activity;

import com.google.android.material.color.DynamicColorsOptions;

public class BraveDynamicColors {
public static void applyToActivityIfAvailable(Activity activity) {
// We disable dynamic colors as it causes styling issues with Brave theme.
}

public static void applyToActivityIfAvailable(
Activity activity, DynamicColorsOptions dynamicColorsOptions) {
// We disable dynamic colors as it causes styling issues with Brave theme.
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
import android.content.Context;
import android.content.res.Resources;
import android.os.Handler;
import android.util.AttributeSet;
import android.view.ActionMode;
import android.view.View;
import android.view.ViewGroup;
Expand Down Expand Up @@ -571,7 +572,7 @@ public void testConstructorsExistAndMatch() throws Exception {
ObservableSupplier.class, BooleanSupplier.class, boolean.class, boolean.class,
boolean.class, boolean.class, boolean.class, HistoryDelegate.class,
BooleanSupplier.class, OfflineDownloader.class, boolean.class,
ObservableSupplier.class, Callback.class));
ObservableSupplier.class, Callback.class, boolean.class, ObservableSupplier.class));
Assert.assertTrue(constructorsMatch(
"org/chromium/chrome/browser/toolbar/menu_button/MenuButtonCoordinator",
"org/chromium/chrome/browser/toolbar/menu_button/BraveMenuButtonCoordinator",
Expand Down Expand Up @@ -609,7 +610,7 @@ public void testConstructorsExistAndMatch() throws Exception {
Assert.assertTrue(constructorsMatch(
"org/chromium/chrome/browser/share/send_tab_to_self/ManageAccountDevicesLinkView",
"org/chromium/chrome/browser/share/send_tab_to_self/BraveManageAccountDevicesLinkView",
Context.class));
Context.class, AttributeSet.class));
Assert.assertTrue(constructorsMatch(
"org/chromium/chrome/browser/suggestions/tile/MostVisitedTilesMediator",
"org/chromium/chrome/browser/suggestions/tile/BraveMostVisitedTilesMediator",
Expand Down
2 changes: 1 addition & 1 deletion app/app_management_strings.grdp
Original file line number Diff line number Diff line change
Expand Up @@ -163,7 +163,7 @@
You can open and edit supported files with this app from the File Explorer or other apps. To control which files open in this app by default, go to <ph name="BEGIN_LINK">&lt;a href="#"&gt;</ph>Windows settings<ph name="END_LINK">&lt;/a&gt;</ph>.
</message>
</if>
<if expr="chromeos_ash or chromeos_lacros">
<if expr="is_chromeos">
<message name="IDS_APP_MANAGEMENT_FILE_HANDLING_SET_DEFAULTS_LINK" desc="Further explanation of the File Handling API, including text describing the purpose of the toggle (referencing the ChromeOS Files app) and a link to a learn more link for default filetype associations.">
You can open and edit supported files with this app from the Files app or other apps. To control which files open this app by default, <ph name="BEGIN_LINK">&lt;a href="#"&gt;</ph>learn how to set default apps on your device<ph name="END_LINK">&lt;/a&gt;</ph>.
</message>
Expand Down
2 changes: 1 addition & 1 deletion app/app_management_strings_override.grdp
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
</message>
<if expr="is_win">
</if>
<if expr="chromeos_ash or chromeos_lacros">
<if expr="is_chromeos">
</if>
<if expr="is_macosx">
</if>
Expand Down
6 changes: 5 additions & 1 deletion app/brave_main_delegate_browsertest.cc
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
#include "build/build_config.h"
#include "chrome/browser/domain_reliability/service_factory.h"
#include "chrome/browser/enterprise/connectors/analysis/content_analysis_features.h"
#include "chrome/browser/prefetch/prefetch_proxy/prefetch_proxy_features.h"
#include "chrome/browser/preloading/prefetch/prefetch_proxy/prefetch_proxy_features.h"
#include "chrome/common/chrome_features.h"
#include "chrome/common/chrome_switches.h"
#include "chrome/test/base/chrome_test_utils.h"
Expand Down Expand Up @@ -89,6 +89,7 @@ IN_PROC_BROWSER_TEST_F(BraveMainDelegateBrowserTest, DisabledFeatures) {
&autofill::features::kAutofillUpstreamAllowAdditionalEmailDomains,
&blink::features::kAdInterestGroupAPI,
&blink::features::kAllowURNsInIframes,
&blink::features::kAnonymousIframeOriginTrial,
&blink::features::kBrowsingTopics,
&blink::features::kClientHintsMetaEquivDelegateCH,
&blink::features::kComputePressure,
Expand Down Expand Up @@ -141,6 +142,7 @@ IN_PROC_BROWSER_TEST_F(BraveMainDelegateBrowserTest, DisabledFeatures) {
&history_clusters::internal::kOmniboxAction,
&history_clusters::internal::kPersistContextAnnotationsInHistoryDb,
&lens::features::kLensStandalone,
&lens::features::kLensUnifiedSidePanelFooter,
&media::kLiveCaption,
&net::features::kNoncedPartitionedCookies,
&net::features::kPartitionedCookies,
Expand All @@ -150,8 +152,10 @@ IN_PROC_BROWSER_TEST_F(BraveMainDelegateBrowserTest, DisabledFeatures) {
&optimization_guide::features::kRemoteOptimizationGuideFetching,
&optimization_guide::features::
kRemoteOptimizationGuideFetchingAnonymousDataConsent,
&password_manager::features::kUnifiedPasswordManagerDesktop,
#if !BUILDFLAG(IS_ANDROID)
&permissions::features::kPermissionsPostPromptSurvey,
&permissions::features::kRecordPermissionExpirationTimestamps,
#endif
&permissions::features::kPermissionOnDeviceNotificationPredictions,
&privacy_sandbox::kOverridePrivacySandboxSettingsLocalTesting,
Expand Down
7 changes: 6 additions & 1 deletion app/chromeos_shared_strings.grdp
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<?xml version='1.0' encoding='UTF-8'?>
<!-- ChromeOS-specific strings (included from generated_resources.grd).
Shared between both Ash and Lacros.
Everything in this file is wrapped in <if expr="chromeos_ash or chromeos_lacros">. -->
Everything in this file is wrapped in <if expr="is_chromeos">. -->
<!--This file is created by l10nUtil.js. Do not edit manually.-->
<grit-part>

Expand Down Expand Up @@ -47,4 +47,9 @@
Read and write access to <ph name="VOLUME_NAME">$1<ex>FooBar 4GB</ex></ph> has been granted.
</message>

<!-- Strings for Plugin VM -->
<message name="IDS_PLUGIN_VM_APP_NAME" desc="Product name for 'Parallels Desktop'. Should not be translated as it is a third party name." translateable="false">
Parallels Desktop
</message>

</grit-part>
6 changes: 6 additions & 0 deletions app/extensions_strings.grdp
Original file line number Diff line number Diff line change
Expand Up @@ -311,6 +311,9 @@
<message name="IDS_EXTENSIONS_ITEM_SOURCE" desc="The label above an extension's source, which indicates where the extension came from (webstore, third-party, local disk, etc).">
Source
</message>
<message name="IDS_EXTENSIONS_ITEM_SOURCE_INSTALLED_BY_DEFAULT" desc="The text to indicate that an extension has been added by default for the user's profile.">
Installed by default
</message>
<message name="IDS_EXTENSIONS_ITEM_SOURCE_POLICY" desc="The text to indicate that an extension has been added by enterprise policy.">
Added by policy
</message>
Expand Down Expand Up @@ -404,6 +407,9 @@
<message name="IDS_EXTENSIONS_SITE_PERMISSIONS_ALL_SITES_PAGE_TITLE" desc="The title for the all sites subpage for extensions site permissions management.">
All sites
</message>
<message name="IDS_EXTENSIONS_SITE_PERMISSIONS_ALL_SITES_EXTENSION_COUNT" desc="The subtext displayed for sites in the all sites subpage showing the number of extensions that can run for that site.">
<ph name="NUM_EXTENSIONS">$1</ph> extensions
</message>
<message name="IDS_EXTENSIONS_PERMITTED_SITES" desc="The label above the list of sites that extensions are always permitted to run in.">
All extensions allowed
</message>
Expand Down
Loading