Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade from Chromium 105 to Chromium 106 #14529

Merged
merged 124 commits into from
Sep 16, 2022
Merged

Upgrade from Chromium 105 to Chromium 106 #14529

merged 124 commits into from
Sep 16, 2022

Conversation

cdesouza-chromium
Copy link
Collaborator

@cdesouza-chromium cdesouza-chromium commented Aug 8, 2022

Resolves brave/brave-browser#24517

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@github-actions github-actions bot added CI/run-audit-deps Check for known npm/cargo vulnerabilities (audit_deps) CI/run-network-audit Run network-audit potential-layer-violation-fixes This PR touches a BUILD.gn file with check_includes=false labels Aug 8, 2022
Copy link
Collaborator

@tmancey tmancey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ads changes LGTM++

@cdesouza-chromium cdesouza-chromium force-pushed the cr106 branch 6 times, most recently from 5d24545 to c2cab8d Compare August 12, 2022 01:02
@emerick emerick self-assigned this Aug 12, 2022
@cdesouza-chromium cdesouza-chromium force-pushed the cr106 branch 4 times, most recently from f2c14c9 to 0d20b1e Compare August 17, 2022 13:49
cdesouza-chromium and others added 20 commits September 15, 2022 20:46
Chromium is adding measures upstreams to prevent language
fingerprinting, some of which were already implemented in brave, and
behave similarly. However, upstream tests rely on these features to be
guarded behind a new flag, while on our overrides, we always apply such
changes.

Chromium change:
https://chromium.googlesource.com/chromium/src/+/ba3e6ea3c8af9e40b6f532d04d9e59d41703b25d

commit ba3e6ea3c8af9e40b6f532d04d9e59d41703b25d
Author: Victor Tan <victortan@chromium.org>
Date:   Fri Aug 12 16:46:28 2022 +0000

    5) Add implementation for reducing navigator.languages

    Implement reduce information on JS api navigator.languages to return the
    language value is the same as that returned by navigator.language.

    Public explainer: https://github.com/Tanych/accept-language

    I2P:
    https://groups.google.com/a/chromium.org/g/blink-dev/c/V4FS3zMbZ08/m/gY02lQaeAgAJ

    Design doc[Google internal]: https://docs.google.com/document/d/1bDaCMJP9w6VJjlM_5nRO1KxyB2fkV3JRtKkfUS0GJ_Y

    Implementation doc:https://docs.google.com/document/d/1RkPDf7DNtcOj4KXeW8wNCuYfto-drnGYST_NvZe3GoY

    Bug: 1323776
We have recently added to brave a dialog to confirm that one is aware
that closing the browser will close multiple tabs. This is causing an
upstream browser test to hang up

For reference:
#13003
Chromium change:

https://source.chromium.org/chromium/chromium/src/+/d8cc01ec95f50e75b972b4285192f12277a30595

commit d8cc01ec95f50e75b972b4285192f12277a30595
Author: Xiaoling Bao <xiaolingbao@chromium.org>
Date:   Fri Aug 5 18:57:24 2022 +0000

    Check in lzma 7zz command for mac.

    The 7zz command originates from: https://7-zip.org/a/7z2107-mac.tar.xz.
    Created lzma_sdk/bin/mac64 folder for the new binary.
    sha1 hash digest:
    c62266f7da3108bef870086c456d002ae8ffe089
    sha256 hash digest:
    c194cd5b88d5cf5842df4f6e5b082ac593780aabc221de01558a4fa58850c43e

    Moved lzma_sdk/bin/7z*.exe to lzma_sdk/bin/win64/7z*.exe and updated the references.

    Bug: 1348343
Chromium change:
https://chromium.googlesource.com/chromium/src/+/91ee380978edabe9dee5774818afbd2b73cef232

commit 91ee380978edabe9dee5774818afbd2b73cef232
Author: dpapad <dpapad@chromium.org>
Date:   Fri Jul 22 21:42:47 2022 +0000

    WebUI: Refactor ui/webui/resources/cr_elements/BUILD.gn.

    So that the same HTML/TS files don't need to be listed multiple times.
    This is in prepration of turning on HTML/CSS minification for
    cr_elements.

    Bug: 1325169
…stream)

Chromium change:

https://source.chromium.org/chromium/chromium/src/+/634330bde7241b6d62d5a3e8600b2dadf66f0b3c

commit 634330bde7241b6d62d5a3e8600b2dadf66f0b3c
Author: Arthur Sonzogni <arthursonzogni@chromium.org>
Date:   Tue Sep 6 09:35:50 2022 +0000

    ProfileDestroyer: Fix error with multiple OTR profile.

    This was reported by Brave developer (Max Karolinskiy):
    https://chromiumdash.appspot.com/commit/cf2ba42acf6977eb009c5d93625d343e6dce6eed

    It was previously suggested to me in:
    https://chromium-review.googlesource.com/c/chromium/src/+/3714294
    to make Profile waits for its OTR profile's RenderProcessHost in
    addition to its own RenderProcessHost. The reason is that
    ScopedProfileKeepAlive the OTR profile keeps on its original profile is
    sometime ignored. This was made for additional safety.

    The issue: the function Profile::GetAllOffTheRecordProfiles() surprisingly
    return something when |this| is an OTR profile. This is confusing.

    This patch:
    - Make use of GetAllOffTheRecordProfiles() for non OTR profile only.
    - Modify TestingProfile::GetAllOffTheRecordProfiles() to match the
      implementation it was meant to represent.
    - Add ProfileDestroyer regression test (unit test)
    - Add Profile regression test (browser test)

    (cherry picked from commit 6dc54e7acd2d293360dc2d3e7b6d79f052354aea)

    Bug: 1357476
This patch is no longer necessary, and an override is being used in its
place.
This change replaces the use of a patch for content_settings_types.h,
with an override.
This change removes the use of a patch file to extend HistogramValue,
and now adds an override for it.
Chromium change:
https://chromium.googlesource.com/chromium/src/+/9dbbbda3d576a40b107535bf18e150ee68f169ad

commit 9dbbbda3d576a40b107535bf18e150ee68f169ad
Author: Anthony Vallee-Dubois <anthonyvd@chromium.org>
Date:   Fri Aug 26 01:25:31 2022 +0000

    Add gnu::abi_tag("logically_const") to base::Feature

    This is in preparation of landing https://chromium-review.googlesource.com/c/chromium/src/+/3683086, which adds a mutable field to base::Feature. Adding the "logically_const" tag in this way will allow the binary_size bot to ignore the fact that const base::Feature objects will now exist in non-readonly sections of the binary.

    Adding this annotation breaks forward declarations, so all of the existing base::Feature forward declarations are replaced by "base/feature_list.h" includes.

    Bug: 1341292
@emerick
Copy link
Contributor

emerick commented Sep 16, 2022

CI passed all platforms; ready to merge.

@emerick emerick merged commit 15a1ea3 into master Sep 16, 2022
@emerick emerick deleted the cr106 branch September 16, 2022 03:11
@emerick emerick added this to the 1.45.x - Nightly milestone Sep 16, 2022
@samartnik
Copy link
Contributor

samartnik commented Sep 19, 2022

emerick added a commit that referenced this pull request Sep 20, 2022
Upgrade from Chromium 105 to Chromium 106
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/run-audit-deps Check for known npm/cargo vulnerabilities (audit_deps) CI/run-network-audit Run network-audit potential-layer-violation-fixes This PR touches a BUILD.gn file with check_includes=false
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade from Chromium 105 to Chromium 106