Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes ads being toggled on #1416

Merged
merged 1 commit into from
Jan 23, 2019
Merged

Fixes ads being toggled on #1416

merged 1 commit into from
Jan 23, 2019

Conversation

NejcZdovc
Copy link
Contributor

@NejcZdovc NejcZdovc commented Jan 22, 2019

Resolves brave/brave-browser#2986

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Verified that these changes build without errors on
    • Windows
    • macOS
    • Linux
  • Verified that these changes pass automated tests (npm test brave_unit_tests && npm test brave_browser_tests) on
    • Windows
    • macOS
    • Linux
  • Ran git rebase master (if needed).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.
  • Request a security/privacy review as needed.
  • Add appropriate QA labels (QA/Yes or QA/No) to include the closed issue in milestone

Test Plan:

pre-requirement

  1. go to 0.59
  2. clean profile
  3. enable rewards via panel
  4. close the bowser
  5. rename profile to development

Test plan

  1. go to this PR
  2. start the browser
  3. go to rewards settings page
  4. make sure that ads are off

Plan 2 (no need for pre-requirement)

  1. clean profile on this PR
  2. create wallet in the panel
  3. make sure that settings page is updated as well / create it via settings page and make sure that panel is enabled / open multiple rewards windows and enable it in one and make sure that all opdate

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

Copy link
Contributor

@ryanml ryanml left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@NejcZdovc NejcZdovc merged commit 5d1639d into master Jan 23, 2019
@NejcZdovc NejcZdovc deleted the ads-toggle branch January 23, 2019 05:34
NejcZdovc added a commit that referenced this pull request Jan 23, 2019
Fixes ads being toggled on
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ads toggle turned on when updated to 0.60.14
3 participants