Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ads toggle turned on when updated to 0.60.14 #2986

Closed
LaurenWags opened this issue Jan 16, 2019 · 4 comments · Fixed by brave/brave-core#1416
Closed

Ads toggle turned on when updated to 0.60.14 #2986

LaurenWags opened this issue Jan 16, 2019 · 4 comments · Fixed by brave/brave-core#1416

Comments

@LaurenWags
Copy link
Member

Description

When I updated my personal Dev profile from 0.60.13 to 0.60.14, Ads became enabled on 0.60.14. That should not have happened. Ads were off (per UI toggle on 0.60.13) but on 0.60.14 Ads UI toggle switched to on.

This did not reproduce with a clean profile. Meaning, clean profile with 0.60.13, enable rewards, toggle Ads off. Update to 0.60.14 and Ads toggle was still off.

Steps to Reproduce

  1. Have a Dev profile with Rewards enabled that you've used for several versions.
  2. Verify Ads toggle is off on 0.60.13.
  3. Update to 0.60.14

Actual result:

Your Ads toggle may be switched on.
adstoggle

Expected result:

Ads toggle should be off.

Reproduces how often:

Unsure, I only have been able to reproduce with my personal profile.

Brave version (brave://version info)

Brave 0.60.14 Chromium: 72.0.3626.53 (Official Build) dev(64-bit)
Revision 98434e6cd182d68ce396daa92e9c6310422e6763-refs/branch-heads/3626@{#620}
OS Mac OS X

Reproducible on current release:

  • Does it reproduce on brave-browser dev/beta builds? Dev

Website problems only:

  • Does the issue resolve itself when disabling Brave Shields?
  • Is the issue reproducible on the latest version of Chrome?

Additional Information

cc @jsecretan @ryanml @brave/legacy_qa

@LaurenWags LaurenWags added this to the 1.x Backlog milestone Jan 16, 2019
@rebron rebron added release/blocking priority/P1 A very extremely bad problem. We might push a hotfix for it. labels Jan 18, 2019
@rebron
Copy link
Collaborator

rebron commented Jan 18, 2019

@LaurenWags @NejcZdovc @jasonrsadler @ryanml is this happening on 59.x?

@LaurenWags
Copy link
Member Author

@rebron iirc this didn't happen all the time (@ryanml had a very tough time reproducing).

@NejcZdovc
Copy link
Contributor

@rebron @LaurenWags I know what the problem is and I will fix it

@NejcZdovc NejcZdovc self-assigned this Jan 22, 2019
NejcZdovc added a commit to brave/brave-core that referenced this issue Jan 22, 2019
@NejcZdovc NejcZdovc modified the milestones: 1.x Backlog, 0.60.x - Dev Jan 23, 2019
@LaurenWags
Copy link
Member Author

LaurenWags commented Feb 11, 2019

Verified passed with

Brave 0.60.23 Chromium: 72.0.3626.96 (Official Build) beta(64-bit)
Revision 84098ee7ef8622a9defc2ef043cd8930b617b10e-refs/branch-heads/3626@{#836}
OS Mac OS X

Verification passed on

Brave 0.60.28 Chromium: 72.0.3626.96 (Official Build) beta (64-bit)
Revision 84098ee7ef8622a9defc2ef043cd8930b617b10e-refs/branch-heads/3626@{#836}
OS Windows 7

Used test plan from brave/brave-core#1416
Installed release version and change the profile to beta.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants