Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Android] Enable crash reporting by default on Nightly/Beta #13314

Closed
wants to merge 1 commit into from

Conversation

AlexeyBarabash
Copy link
Contributor

@AlexeyBarabash AlexeyBarabash commented May 12, 2022

Resolves brave/brave-browser#19857

This PR enables crash reporting by default on Nightly/Beta for new installations.

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one SECURITY REVIEW IS REQUIRED, PENDING
    https://github.com/brave/security/issues/860
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

I. Nightly/Beta, fresh installation

  1. Install Nightly/Beta browser as a fresh install
  2. Go to Settings => Brave Shields & privacy
  3. Ensure Automatically send diagnostic reports is turned on

II. Nightly/Beta, update installation

  1. Open Nightly/Beta browser
  2. At Settings => Brave Shields & privacy uncheck Automatically send diagnostic reports
  3. Install Nightly/Beta browser as an update install
  4. Go to Settings => Brave Shields & privacy
  5. Ensure Automatically send diagnostic reports is still turned off

III. Stable, fresh installation

  1. Install Stable browser as a fresh install
  2. Go to Settings => Brave Shields & privacy
  3. Ensure Automatically send diagnostic reports is turned off

IV. Stable, fresh installation

  • similar to III. Stable, fresh installation

Note: Beta and Stable are not available yet, but it is possible to test that with own master-based builds.

@AlexeyBarabash AlexeyBarabash added enhancement CI/skip Do not run CI builds (except noplatform) CI/skip-linux CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-ios Do not run CI builds for iOS labels May 12, 2022
@AlexeyBarabash AlexeyBarabash self-assigned this May 12, 2022
@AlexeyBarabash AlexeyBarabash removed the CI/skip Do not run CI builds (except noplatform) label May 12, 2022
@AlexeyBarabash AlexeyBarabash marked this pull request as ready for review May 12, 2022 19:46
@AlexeyBarabash AlexeyBarabash force-pushed the android_crash_report_on_nightly branch from 1cc486a to 5540cbb Compare May 12, 2022 19:46
@github-actions github-actions bot removed the rebase label May 12, 2022
Copy link
Contributor

@samartnik samartnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@AlexeyBarabash AlexeyBarabash changed the title [Android] Enable crash reporting by default on Nightly [Android] Enable crash reporting by default on Nightly/Beta May 12, 2022
Copy link
Member

@SergeyZhukovsky SergeyZhukovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@AlexeyBarabash AlexeyBarabash added this to the 1.40.x - Nightly milestone May 12, 2022
Copy link
Contributor

@deeppandya deeppandya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@wchen342 wchen342 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm:+1:

@AlexeyBarabash
Copy link
Contributor Author

Closing this, as onboarding PR #13405 handles this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/skip-ios Do not run CI builds for iOS CI/skip-macos-x64 Do not run CI builds for macOS x64 enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable crash reporting on Android for Nightly channel only
5 participants