-
Notifications
You must be signed in to change notification settings - Fork 920
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Android] Enable crash reporting by default on Nightly/Beta #13314
Conversation
for new installations fixes brave/brave-browser#19857
1cc486a
to
5540cbb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
++
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm:+1:
Closing this, as onboarding PR #13405 handles this. |
Resolves brave/brave-browser#19857
This PR enables crash reporting by default on Nightly/Beta for new installations.
Submitter Checklist:
SECURITY REVIEW IS REQUIRED, PENDINGhttps://github.com/brave/security/issues/860
QA/Yes
orQA/No
;release-notes/include
orrelease-notes/exclude
;OS/...
) to the associated issuenpm run test -- brave_browser_tests
,npm run test -- brave_unit_tests
,npm run lint
,npm run gn_check
,npm run tslint
git rebase master
(if needed)Reviewer Checklist:
gn
After-merge Checklist:
changes has landed on
Test Plan:
I. Nightly/Beta, fresh installation
Settings
=>Brave Shields & privacy
Automatically send diagnostic reports
is turned onII. Nightly/Beta, update installation
Settings
=>Brave Shields & privacy
uncheckAutomatically send diagnostic reports
Settings
=>Brave Shields & privacy
Automatically send diagnostic reports
is still turned offIII. Stable, fresh installation
Settings
=>Brave Shields & privacy
Automatically send diagnostic reports
is turned offIV. Stable, fresh installation
III. Stable, fresh installation
Note: Beta and Stable are not available yet, but it is possible to test that with own master-based builds.