Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hide userAgentData model #11932

Merged
merged 3 commits into from
Jan 31, 2022
Merged

Hide userAgentData model #11932

merged 3 commits into from
Jan 31, 2022

Conversation

pilgrim-brave
Copy link
Contributor

@pilgrim-brave pilgrim-brave commented Jan 20, 2022 •
edited
Loading

Resolves brave/brave-browser#20499

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@pilgrim-brave pilgrim-brave requested a review from a team as a code owner January 20, 2022 17:45
@pilgrim-brave pilgrim-brave self-assigned this Jan 20, 2022
goodov
goodov approved these changes Jan 28, 2022
View reviewed changes
Copy link
Member

@goodov goodov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++ with few nits.

@pilgrim-brave pilgrim-brave merged commit fb20d5e into master Jan 31, 2022
@pilgrim-brave pilgrim-brave deleted the mpilgrim_ua_model branch January 31, 2022 21:24
@pilgrim-brave pilgrim-brave restored the mpilgrim_ua_model branch February 1, 2022 17:53
brave-builds pushed a commit that referenced this pull request Feb 1, 2022
@brave-browser-releases
Uplift of #11932 (squashed) to beta
9d3862f
brave-builds pushed a commit that referenced this pull request Feb 1, 2022
@brave-browser-releases
Uplift of #11932 (squashed) to release
80c8bd8
This was referenced Feb 1, 2022
Merged
Merged
@kjozwiak kjozwiak added this to the 1.37.x - Nightly milestone Feb 2, 2022
@kjozwiak kjozwiak deleted the mpilgrim_ua_model branch February 2, 2022 17:25
@kjozwiak
Copy link
Member

kjozwiak commented Feb 2, 2022

Verification PASSED on Pixel 6 running Android 12 using 1.37.17 Chromium: 98.0.4758.87

1.34.81 Chromium: 97.0.4692.99 1.37.17 Chromium: 98.0.4758.87
Screenshot_20220202-121837 Screenshot_20220202-121857

muliswilliam pushed a commit that referenced this pull request Feb 8, 2022
@pilgrim-brave @muliswilliam
Hide userAgentData model (#11932)
674c8d9 
* Hide userAgentData model

* lint

* nits
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@goodov goodov goodov approved these changes

Assignees

@pilgrim-brave pilgrim-brave

Labels
None yet
Projects
None yet
Milestone
1.37.x - Release
Development

Successfully merging this pull request may close these issues.

Phone model leaking with navigator
3 participants
@pilgrim-brave @kjozwiak @goodov