Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Phone model leaking with navigator #20499

Closed
ghost opened this issue Jan 14, 2022 · 3 comments · Fixed by brave/brave-core#11932
Closed

Phone model leaking with navigator #20499

ghost opened this issue Jan 14, 2022 · 3 comments · Fixed by brave/brave-core#11932
Assignees
Labels
feature/shields/fingerprint The fingerprinting (aka: "device recognition") protection provided in Shields OS/Android Fixes related to Android browser functionality QA Pass - Android ARM QA Pass - Android Tab QA/Yes release-notes/include

Comments

@ghost
Copy link

ghost commented Jan 14, 2022

Description

Users phone model leaks with javascript navigator

Steps to Reproduce

  1. Go to https://abrahamjuliot.github.io/creepjs/
  2. Scroll dowm
  3. See your phone model being shown

Actual result:

Expected result:

The results should be faked, or brave should disable the feature by default

Reproduces how often:

Easily reproduced

Desktop Brave version:

Android Device details:

  • Install type (ARM, x86): arm
  • Device type (Phone, Tablet, Phablet): phone
  • Android version: 10

Version/Channel Information:

Every brave versions and channels seems to have this issue

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? No
  • Does the issue resolve itself when disabling Brave Rewards? No
  • Is the issue reproducible on the latest version of Chrome? Yes, but chrome dose not aim for hiding users phone model

Miscellaneous Information:

@ghost ghost added OS/Android Fixes related to Android browser functionality OS/Desktop labels Jan 14, 2022
@diracdeltas
Copy link
Member

cc @pes10k - i know we discussed removing phone model in android UA but not sure if we actually did it

@pes10k
Copy link
Contributor

pes10k commented Jan 19, 2022

Yea, @pilgrim-brave did, back in brave/brave-core#8320 and brave/brave-core#8562 . I don't have an android device to test with. @pilgrim-brave could you take a look tomorrow when you're online?

@srirambv
Copy link
Contributor

srirambv commented Feb 9, 2022

Verification passed on the following devices running 1.35.101 x64 build

  • Verified steps from issue description
  • Verified phone model is not shown
Oppo Reno 5 (Android 11) Samsung Tab A (Android 10)
20499-Android.ARM.mp4
20499-Android.Tab.mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/shields/fingerprint The fingerprinting (aka: "device recognition") protection provided in Shields OS/Android Fixes related to Android browser functionality QA Pass - Android ARM QA Pass - Android Tab QA/Yes release-notes/include
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants