Goal is to securely expose Google Play Store purchase token for Brave…

… VPN to Brave owned websites (account.brave.com). Part of overall change required to solve brave/brave-browser#21942
brave · Jul 5, 2022 · 50edfc6 · 50edfc6
1 parent cf53061
commit 50edfc6
Show file tree

Hide file tree

Showing 5 changed files with 32 additions and 1 deletion.
diff --git a/browser/brave_vpn/brave_vpn_service_factory.cc b/browser/brave_vpn/brave_vpn_service_factory.cc
@@ -97,6 +97,7 @@ KeyedService* BraveVpnServiceFactory::BuildServiceInstanceFor(
 #endif
   return vpn_service;
 #elif BUILDFLAG(IS_ANDROID)
+  // TODO(bsclifton): this needs to change here because it needs to init mojom
   return new BraveVpnService(shared_url_loader_factory, callback);
 #endif
 }

diff --git a/components/brave_vpn/brave_vpn_service.cc b/components/brave_vpn/brave_vpn_service.cc
@@ -858,6 +858,8 @@ BraveVPNOSConnectionAPI* BraveVpnService::GetBraveVPNConnectionAPI() {
   return BraveVPNOSConnectionAPI::GetInstance();
 }
 
+// NOTE(bsclifton): Desktop uses API to create a ticket.
+// Android and iOS directly send an email.
 void BraveVpnService::OnCreateSupportTicket(
     CreateSupportTicketCallback callback,
     int status,
@@ -870,6 +872,19 @@ void BraveVpnService::OnCreateSupportTicket(
 }
 #endif  // !BUILDFLAG(IS_ANDROID)
 
+#if BUILDFLAG(IS_ANDROID)
+
+void BraveVpnService::GetPurchaseToken(GetPurchaseTokenCallback callback) {
+  // TODO(bsclifton): get the real purchase token
+
+  std::move(callback).Run(
+      "oohdhbmbebmciddpbcicgnko.AO-J1OxJGS6-"
+      "tNYvzofx7RO2hJSEgQmi6tOrLHEB4zJ2OhsyhX3mhEe4QKS0MVxtJCBNIAlBP5jAgDPqdXDN"
+      "z15JhIXt5QYcIExIxe5H5ifbhAsHILlUXlE");
+}
+
+#endif
+
 void BraveVpnService::AddObserver(
     mojo::PendingRemote<mojom::ServiceObserver> observer) {
   DCHECK_CALLED_ON_VALID_SEQUENCE(sequence_checker_);

diff --git a/components/brave_vpn/brave_vpn_service.h b/components/brave_vpn/brave_vpn_service.h
@@ -113,6 +113,10 @@ class BraveVpnService :
   void GetSupportData(GetSupportDataCallback callback) override;
 #endif  // !BUILDFLAG(IS_ANDROID)
 
+#if BUILDFLAG(IS_ANDROID)
+  void GetPurchaseToken(GetPurchaseTokenCallback callback) override;
+#endif  // BUILDFLAG(IS_ANDROID)
+
   using ResponseCallback =
       base::OnceCallback<void(const std::string&, bool success)>;
 

diff --git a/components/brave_vpn/features.cc b/components/brave_vpn/features.cc
@@ -6,12 +6,20 @@
 #include "brave/components/brave_vpn/features.h"
 
 #include "base/feature_list.h"
+#include "build/build_config.h"
 
 namespace brave_vpn {
 
 namespace features {
 
-const base::Feature kBraveVPN{"BraveVPN", base::FEATURE_DISABLED_BY_DEFAULT};
+const base::Feature kBraveVPN {
+  "BraveVPN",
+#if BUILDFLAG(IS_ANDROID)
+      base::FEATURE_DISABLED_BY_DEFAULT
+#else
+      base::FEATURE_DISABLED_BY_DEFAULT
+#endif
+};
 
 }  // namespace features
 

diff --git a/components/brave_vpn/mojom/brave_vpn.mojom b/components/brave_vpn/mojom/brave_vpn.mojom
@@ -81,6 +81,9 @@ interface ServiceHandler {
 
   [EnableIfNot=is_android]
   CreateSupportTicket(string email, string subject, string body) => (bool success, string response);
+
+  [EnableIf=is_android]
+  GetPurchaseToken() => (string token);
 };
 
 // WebUI-side handler for requests from the browser.