-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expose Android purchase token for VPN purchase for Premium Services website #21942
Labels
feature/vpn
OS/Android
Fixes related to Android browser functionality
QA Pass - Android ARM
QA Pass - Android Tab
QA/Test-Plan-Specified
QA/Yes
release-notes/exclude
Milestone
Comments
bsclifton
added a commit
to brave/brave-core
that referenced
this issue
Apr 22, 2022
Goal is to securely expose Google Play Store purchase token for Brave VPN to Brave owned websites (account.brave.com). Fixes brave/brave-browser#21942
bsclifton
added a commit
to brave/brave-core
that referenced
this issue
May 19, 2022
Goal is to securely expose Google Play Store purchase token for Brave VPN to Brave owned websites (account.brave.com). Fixes brave/brave-browser#21942
25 tasks
bsclifton
added a commit
to brave/brave-core
that referenced
this issue
May 24, 2022
Goal is to securely expose Google Play Store purchase token for Brave VPN to Brave owned websites (account.brave.com). Fixes brave/brave-browser#21942
bsclifton
added a commit
to brave/brave-core
that referenced
this issue
May 26, 2022
Goal is to securely expose Google Play Store purchase token for Brave VPN to Brave owned websites (account.brave.com). Fixes brave/brave-browser#21942
bsclifton
added a commit
to brave/brave-core
that referenced
this issue
May 27, 2022
Goal is to securely expose Google Play Store purchase token for Brave VPN to Brave owned websites (account.brave.com). Fixes brave/brave-browser#21942
bsclifton
added a commit
to brave/brave-core
that referenced
this issue
Jun 14, 2022
Goal is to securely expose Google Play Store purchase token for Brave VPN to Brave owned websites (account.brave.com). Fixes brave/brave-browser#21942
bsclifton
added a commit
to brave/brave-core
that referenced
this issue
Jun 15, 2022
Goal is to securely expose Google Play Store purchase token for Brave VPN to Brave owned websites (account.brave.com). Fixes brave/brave-browser#21942
bsclifton
added a commit
to brave/brave-core
that referenced
this issue
Jun 15, 2022
… VPN to Brave owned websites (account.brave.com). Fixes brave/brave-browser#21942
bsclifton
added a commit
to brave/brave-core
that referenced
this issue
Jun 23, 2022
… VPN to Brave owned websites (account.brave.com). Fixes brave/brave-browser#21942
bsclifton
added a commit
to brave/brave-core
that referenced
this issue
Jun 27, 2022
… VPN to Brave owned websites (account.brave.com). Fixes brave/brave-browser#21942
bsclifton
added a commit
to brave/brave-core
that referenced
this issue
Jul 5, 2022
… VPN to Brave owned websites (account.brave.com). Part of overall change required to solve brave/brave-browser#21942
bsclifton
added a commit
to brave/brave-core
that referenced
this issue
Jul 19, 2022
… VPN to Brave owned websites (account.brave.com). Part of overall change required to solve brave/brave-browser#21942
spylogsster
pushed a commit
to brave/brave-core
that referenced
this issue
Jul 19, 2022
… VPN to Brave owned websites (account.brave.com). Part of overall change required to solve brave/brave-browser#21942
bsclifton
added a commit
to brave/brave-core
that referenced
this issue
Jul 28, 2022
… VPN to Brave owned websites (account.brave.com). Part of overall change required to solve brave/brave-browser#21942 - updates to VPN service to simplify Android implementation - set VPN as enabled by default on Android (since it's live now) - creating Android specific render frame observer which can write blob to local storage `GetPurchaseToken` is only meant for Android but can be run on all platforms (for testing purposes)
bsclifton
added a commit
to brave/brave-core
that referenced
this issue
Aug 4, 2022
Goal is to securely expose Google Play Store purchase token for Brave VPN to Brave owned websites (account.brave.com). Part of overall change required to solve brave/brave-browser#21942 - updates to VPN service to simplify Android implementation - set VPN as enabled by default on Android (since it's live now) - creating Android specific render frame observer which can write blob to local storage
deeppandya
pushed a commit
to brave/brave-core
that referenced
this issue
Aug 12, 2022
… VPN to Brave owned websites (account.brave.com). Part of overall change required to solve brave/brave-browser#21942 - updates to VPN service to simplify Android implementation - set VPN as enabled by default on Android (since it's live now) - creating Android specific render frame observer which can write blob to local storage `GetPurchaseToken` is only meant for Android but can be run on all platforms (for testing purposes)
Verified on
Using the test plan in #21942 (comment)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
feature/vpn
OS/Android
Fixes related to Android browser functionality
QA Pass - Android ARM
QA Pass - Android Tab
QA/Test-Plan-Specified
QA/Yes
release-notes/exclude
Test plan
A bit complex; you'll need an Android phone which you'll connect remotely using a Desktop instance of Brave
On the phone
On a desktop machine
inspect
to pop open the dev tools. It should look like the picture here: Cross platform integration (Android) brave-core#13387 (comment)Inside the dev tools window (on Desktop) for your mobile device
?intent=connect-receipt&product=vpn
to the end of the URLApplication
tabSession Storage
value with keybraveVpn.receipt
and you should see a valueDecoding the
braveVpn.receipt
valueSession Storage
in dev tools)atob('<string value you copied>')
Description
Related to https://github.com/brave/account-brave-com/issues/24
Basically, for folks that have purchased the VPN product using the in-app-purchase (IAP) mechanism on Android, we should write a blob with the receipt information into local storage with the key
braveVpn.receipt
.This will be a base64 encoded JSON blob in a format like:
This should ONLY be exposed when on the Brave Premium website (account.brave.com / account.bravesoftware.com / account.brave.software). For the implementation, we can use a render frame observer to inject this method onto the page
Implementation for this needs to be security/privacy reviewed
The text was updated successfully, but these errors were encountered: