Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Moving google api key to the proxy #865

Closed
wants to merge 1 commit into from

Conversation

jumde
Copy link
Contributor

@jumde jumde commented Aug 28, 2018

Fix #864

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Verified that these changes build without errors on
    • Windows
    • macOS
    • Linux
  • Verified that these changes pass automated tests (npm test brave_unit_tests && npm test brave_browser_tests) on
    • Windows
    • macOS
    • Linux
  • Ran git rebase master (if needed).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.
  • Requested a security/privacy review as needed.

Test Plan:

  1. Load brave browser
  2. Veriy if *.store files have been created in <DATA_DIR>/Safe Browsing
  3. Navigate to testsafebrowsing.appspot.com and check if the tests are working as expected.

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions.

@jumde jumde force-pushed the resetting_google_api_key branch from 4082c63 to 45b81bc Compare August 28, 2018 17:09
@bbondy bbondy changed the title Moving google api key to the proxy WIP: Moving google api key to the proxy Mar 1, 2019
@jumde
Copy link
Contributor Author

jumde commented Oct 27, 2021

closing as stale

@jumde jumde closed this Oct 27, 2021
@jumde jumde deleted the resetting_google_api_key branch October 27, 2021 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move Safe Browsing key to proxy
3 participants