Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Safe Browsing key to proxy #864

Closed
jumde opened this issue Aug 28, 2018 · 1 comment
Closed

Move Safe Browsing key to proxy #864

jumde opened this issue Aug 28, 2018 · 1 comment

Comments

@jumde
Copy link
Contributor

jumde commented Aug 28, 2018

Do not include the key in code or client, instead move it to the proxy. We will use anidentifier instead of the real key in the code, modify the request at the proxy to replace the identifier with the key and add rate limiting at the proxy to avoid abuse

@fmarier
Copy link
Member

fmarier commented Nov 1, 2021

I'm not sure when this was done, but the key is in fact on the proxy. The client only has a dummy key:
https://github.com/brave/brave-core/blob/44bbdfdd8e21a1aa79f1bd473c27c46278f664d2/build/commands/lib/config.js#L95

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants