Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create new build_policy_templates action for generating group policy resources #41217

Closed
bsclifton opened this issue Sep 23, 2024 · 1 comment
Closed

Create new build_policy_templates action for generating group policy resources #41217

bsclifton opened this issue Sep 23, 2024 · 1 comment
Assignees
@bsclifton
Labels
closed/invalid dev-concern OS/Desktop QA/No release-notes/exclude

Comments

@bsclifton
Copy link
Member

Description

Currently, the build will run the //brave/components/policy:pack_policy_templates action during create_dist
https://github.com/brave/brave-core/blob/83163606814abf46591e1f9566ad3bd1746932e7/BUILD.gn#L302

This should be broken out so that we can run ONLY that step when we'd like.

A good name might be build_policy_templates. For example npm run build_policy_templates
@bsclifton bsclifton self-assigned this Sep 23, 2024
bsclifton added a commit to brave/brave-core that referenced this issue Sep 23, 2024
@bsclifton
Add new build_policy_templates action
5e4cfd3 
Currently, group policy is only generated during `create_dist`.
This allows us to quickly create `policy_templates.zip` and the Brave
specific version `brave_policy_templates.zip`.

Fixes brave/brave-browser#41217
@bsclifton bsclifton mentioned this issue Sep 23, 2024
Closed
24 tasks
bsclifton added a commit to brave/brave-core that referenced this issue Sep 23, 2024
@bsclifton
Add new build_policy_templates action
d3c2391 
Currently, group policy is only generated during `create_dist`.
This allows us to quickly create `policy_templates.zip` and the Brave
specific version `brave_policy_templates.zip`.

Fixes brave/brave-browser#41217
bsclifton added a commit to brave/brave-core that referenced this issue Sep 23, 2024
@bsclifton
Add new build_policy_templates action
b8ef347 
Currently, group policy is only generated during `create_dist`.
This allows us to quickly create `policy_templates.zip` and the Brave
specific version `brave_policy_templates.zip`.

Fixes brave/brave-browser#41217
bsclifton added a commit to brave/brave-core that referenced this issue Sep 24, 2024
@bsclifton
Add new build_policy_templates action
581734d 
Currently, group policy is only generated during `create_dist`.
This allows us to quickly create `policy_templates.zip` and the Brave
specific version `brave_policy_templates.zip`.

Fixes brave/brave-browser#41217
bsclifton added a commit to brave/brave-core that referenced this issue Sep 24, 2024
@bsclifton
Add new build_policy_templates action
56c29c6 
Currently, group policy is only generated during `create_dist`.
This allows us to quickly create `policy_templates.zip` and the Brave
specific version `brave_policy_templates.zip`.

Fixes brave/brave-browser#41217
bsclifton added a commit to brave/brave-core that referenced this issue Sep 24, 2024
@bsclifton
Add new build_policy_templates action
a848f85 
Currently, group policy is only generated during `create_dist`.
This allows us to quickly create `policy_templates.zip` and the Brave
specific version `brave_policy_templates.zip`.

Fixes brave/brave-browser#41217
bsclifton added a commit to brave/brave-core that referenced this issue Sep 24, 2024
@bsclifton
Add new build_policy_templates action
30d6814 
Currently, group policy is only generated during `create_dist`.
This allows us to quickly create `policy_templates.zip` and the Brave
specific version `brave_policy_templates.zip`.

Fixes brave/brave-browser#41217
bsclifton added a commit to brave/brave-core that referenced this issue Sep 24, 2024
@bsclifton
Add new build_policy_templates action
a0a2231 
Currently, group policy is only generated during `create_dist`.
This allows us to quickly create `policy_templates.zip` and the Brave
specific version `brave_policy_templates.zip`.

Fixes brave/brave-browser#41217
@bsclifton bsclifton mentioned this issue Sep 25, 2024
Merged
24 tasks
bsclifton added a commit to brave/brave-core that referenced this issue Oct 1, 2024
@bsclifton
Add new build_policy_templates action
0bb4295 
Currently, group policy is only generated during `create_dist`.
This allows us to quickly create `policy_templates.zip` and the Brave
specific version `brave_policy_templates.zip`.

Fixes brave/brave-browser#41217
@bsclifton
Copy link
Member Author

Closing - this would just be a convenience method. Person can instead just add an alias on their local machine for npm run build -- --target=brave/components/policy:pack_policy_templates

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bsclifton bsclifton

Labels
closed/invalid dev-concern OS/Desktop QA/No release-notes/exclude
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add new build_policy_templates action brave/brave-core
1 participant
@bsclifton