-
Notifications
You must be signed in to change notification settings - Fork 922
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new build_policy_templates
action
#25699
Conversation
The security team is monitoring all repositories for certain keywords. This PR includes the word(s) "policy" and so security team members have been added as reviewers to take a look. |
56c29c6
to
a848f85
Compare
Currently, group policy is only generated during `create_dist`. This allows us to quickly create `policy_templates.zip` and the Brave specific version `brave_policy_templates.zip`. Fixes brave/brave-browser#41217
a848f85
to
30d6814
Compare
@@ -46,7 +46,8 @@ | |||
"gen_env": "node ./build/commands/scripts/genEnv.js", | |||
"gen_gradle": "node ./build/commands/scripts/commands.js gen_gradle", | |||
"ios_pack_js": "webpack --config ios/brave-ios/webpack.config.js", | |||
"ios_bootstrap": "node ./build/commands/scripts/iosCommands.js ios_bootstrap" | |||
"ios_bootstrap": "node ./build/commands/scripts/iosCommands.js ios_bootstrap", | |||
"build_policy_templates": "node ./build/commands/scripts/commands.js build --target=brave_group_policy_templates" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One thing I would comment here: Are we sure we want to create a separate npm command for this? Invokers can just as well do npm run build --target=brave/brave_group_policy_templates
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll close this in favor of #25710 |
Currently, group policy is only generated during
create_dist
. This allows us to quickly createpolicy_templates.zip
and the Brave specific versionbrave_policy_templates.zip
.Fixes brave/brave-browser#41217
Submitter Checklist:
QA/Yes
orQA/No
;release-notes/include
orrelease-notes/exclude
;OS/...
) to the associated issuenpm run test -- brave_browser_tests
,npm run test -- brave_unit_tests
wikinpm run presubmit
wiki,npm run gn_check
,npm run tslint
git rebase master
(if needed)Reviewer Checklist:
gn
After-merge Checklist:
changes has landed on
Test Plan:
src/brave
folder, runnpm run build_policy_templates
src/out/Component/policy_templates.zip
andsrc/out/Component/brave_policy_templates.zip
were generated