Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(Wallet) Show full network name in status bar of BuySendSwapActivity #30341

Closed
simoarpe opened this issue May 15, 2023 · 1 comment · Fixed by brave/brave-core#18866
Closed

(Wallet) Show full network name in status bar of BuySendSwapActivity #30341

simoarpe opened this issue May 15, 2023 · 1 comment · Fixed by brave/brave-core#18866
Assignees
@simoarpe
Labels
feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass - Android ARM QA Pass - Android Tab QA/Yes release-notes/include
Milestone
1.57.x - Release

Comments

@simoarpe
Copy link

simoarpe commented May 15, 2023 •
edited
Loading

Related to brave/brave-core#18144
Related to #30340
Related to #30402

Description

Emerged during security review for Filecoin support: with the current UI is not clearly indicative of which network the user is on as the networks are displayed with an abbreviate form. With Filecoins for example, both Filecoin mainnet and Filecoin testnet appear as the same text "Filecoin" with no way to easily differentiate which network is in use.

Security_review_for_Filecoin_network_support_·_Issue__1256_·_brave_security

⚠️ Note: enable Filecoin support once #30340, #30341, and #30402 will be addressed.
@simoarpe simoarpe added priority/P2 A bad problem. We might uplift this to the next planned release. QA/Yes release-notes/include feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality labels May 15, 2023
@simoarpe simoarpe added this to Web3 May 15, 2023
This was referenced May 15, 2023
Closed
Closed
Merged
Closed
@HEagle18 HEagle18 moved this to Backlog in Web3 Jun 9, 2023
@simoarpe simoarpe moved this from Backlog to In Progress in Web3 Jun 12, 2023
@simoarpe simoarpe mentioned this issue Jun 12, 2023
Merged
25 tasks
@simoarpe simoarpe self-assigned this Jun 12, 2023
@simoarpe simoarpe moved this from In Progress to In Review in Web3 Jun 12, 2023
@github-project-automation github-project-automation bot moved this from In Review to Done in Web3 Jun 13, 2023
@brave-builds brave-builds added this to the 1.54.x - Nightly milestone Jun 13, 2023
@srirambv
Copy link
Contributor

Verification passed on the following devices running 1.57.18 x64 Beta build

Oppo Reno 5 (Android 13) Lenovo Tab (Android 12)
30341-ARM.mp4
30341-Tab.mp4

@kjozwiak kjozwiak mentioned this issue Aug 15, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@simoarpe simoarpe

Labels
feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass - Android ARM QA Pass - Android Tab QA/Yes release-notes/include
Projects
Web3
Archived in project
Milestone
1.57.x - Release
Development

Successfully merging a pull request may close this issue.

(Wallet) Show full network name in the status bar brave/brave-core
3 participants
@simoarpe @srirambv @brave-builds