Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(Wallet) Ellipsify contract address in status bar of BuySendSwapActivity #30340

Closed
simoarpe opened this issue May 15, 2023 · 1 comment · Fixed by brave/brave-core#18862
Closed

(Wallet) Ellipsify contract address in status bar of BuySendSwapActivity #30340

simoarpe opened this issue May 15, 2023 · 1 comment · Fixed by brave/brave-core#18862
Assignees
@simoarpe
Labels
android-phone-specific feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass - Android ARM QA/Yes release-notes/include
Milestone
1.57.x - Release

Comments

@simoarpe
Copy link

simoarpe commented May 15, 2023 •
edited
Loading

Related to brave/brave-core#18144
Releated to #30341
Related to #30402

Description

Emerged during security review for Filecoin support: there's evidence of attacks where attackers have found ways to specifically craft addresses in a way that can trick the user into thinking their transacting with the wrong address. Here's an example of how that was conducted in Metamask.
Ideally, we should display the full address to make it easier to spot these issues. If there's not enough room available, we should default to the same logic adopted by iOS where we display the first 4 and last 4 characters.

image

⚠️ Note: enable Filecoin support once #30340, #30341, and #30402 will be addressed.
@simoarpe simoarpe added priority/P2 A bad problem. We might uplift this to the next planned release. QA/Yes release-notes/include feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality labels May 15, 2023
@simoarpe simoarpe added this to Web3 May 15, 2023
This was referenced May 15, 2023
Closed
Closed
Merged
Closed
@HEagle18 HEagle18 moved this to Backlog in Web3 Jun 2, 2023
@simoarpe simoarpe mentioned this issue Jun 12, 2023
Merged
25 tasks
@simoarpe simoarpe moved this from Backlog to In Progress in Web3 Jun 12, 2023
@simoarpe simoarpe self-assigned this Jun 12, 2023
@simoarpe simoarpe moved this from In Progress to In Review in Web3 Jun 12, 2023
@github-project-automation github-project-automation bot moved this from In Review to Done in Web3 Jun 13, 2023
@brave-builds brave-builds added this to the 1.54.x - Nightly milestone Jun 13, 2023
@srirambv
Copy link
Contributor

Verification passed on Oppo Reno 5 with Android 13 running 1.57.27 x64 Beta build

30340.mp4

@kjozwiak kjozwiak mentioned this issue Aug 15, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@simoarpe simoarpe

Labels
android-phone-specific feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass - Android ARM QA/Yes release-notes/include
Projects
Web3
Archived in project
Milestone
1.57.x - Release
Development

Successfully merging a pull request may close this issue.

(Wallet) Ellipsify contract address in the middle brave/brave-core
3 participants
@simoarpe @srirambv @brave-builds