Crash reporting prompt on release channel #1841

tildelowengrimm · 2018-10-25T17:55:49Z

Description

In dev and beta, crash reporting is on by default and folks can turn it off if they really want to. On release channel, we should ask folks if they want to send us reports. They're probably most likely to be in the right headspace for that question right after the browser has crashed — there's a motivation to send the report to prevent this specific crash from happening in future releases.

After a crash, when the browser restarts, we should ask whether to send crash reports. The possible answers should be always/yes/no/never or ideas to that effect.

Design

Show a user-blocking modal requesting permission to automatically send crash reports when the app re-opens after a crash. This dialog should take precendence over any other user-blocking dialog (e.g. the 'set Brave as default browser' dialog that occurs on 2nd launch).

"This setting" links to the crash reports item in brave://settings

Assets

Figma: https://www.figma.com/file/pVwKlNQJU9wTVOa9tImKpo/Browser-Dialogs?node-id=36%3A810

The text was updated successfully, but these errors were encountered:

srirambv · 2018-10-25T18:18:45Z

Crash reporting is not enabled by default on Dev and Beta or any channel. #1630 is logged to enable it since we mention its enabled on the download page

cc: @rebron

rebron · 2020-05-05T18:46:26Z

Note to take a look at info bar and using onboarding to set crash reporting pref.

iefremov · 2020-05-05T18:52:08Z

We may also try to be a bit more proactive - e.g. suggest sending a crashdump after an actual crash. Or anything like this to encourage the existing auditory to toggle the switch.

iefremov · 2020-09-18T17:22:08Z

P3A metric proved that almost nobody enables crash reporting on release channel. We definitely should raise the priority of this to start getting some real data from stable clients.

karenkliu · 2021-03-02T20:09:42Z

@rebron WDYT about this crash reports dialog text?

simonhong · 2021-07-19T12:15:03Z

@rebron This new dialog should be visible before restore pages dialog?
Oops, @karenkliu already commented about this :)

simonhong · 2021-07-21T02:16:28Z

Working on this.
@rebron @karenkliu , With current dialog design, we give two options, block or allow.
If user selects block, we will not show this dialog again for the future crash?

karenkliu · 2021-07-21T17:38:22Z

@simonhong If user selects block, we still show the dialog again after future crash(es).

fix brave/brave-browser#1841 Launch crash reporting permission ask dialog on startup after crash. Launch tab restore dialog after permission ask dialog is closed. By overriding, ShowIfNotOffTheRecordProfileBrave() is called instead of ShowIfNotOffTheRecordProfile(). ShowIfNotOffTheRecordProfileBrave() will launch crash reporting permission ask dialog and then tab restore dialog is launched after permission ask dialog is closed.

stephendonner · 2021-08-02T21:55:07Z

Verified PASSED using the testplan from brave/brave-core#9508 with build

Brave	1.29.45 Chromium: 92.0.4515.115 (Official Build) nightly (x86_64)
Revision	48cb2f4029b84b003719740a6cf9ca73f374a857-refs/branch-heads/4515_105@{#4}
OS	macOS Version 12.0 (Build 21A5294g)

Steps:

new profile
launched Brave and opened several tabs
checked and confirmed crash reporting is not enabled on brave://settings/privacy
loaded brave://inducebrowsercrashforrealz to simulate browser crash
restarted Brave
confirmed crash reporting permission ask dialog was launched
confirmed clicking on this settings opens brave://settings/privacy in the background (still a modal window displayed)
clicked Block and confirmed tab-restore bubble was displayed
clicked Allow and confirmed the tab-restore bubble was displayed
confirmed crash reporting is now enabled from brave://settings/privacy
also confirmed the user will see this dialog on restart, after each crash, unless they click Allow, in which it will be a silent crash-report submission (per Crash reporting prompt on release channel #1841 (comment))

default crash-reporting pref (disabled)	crash reporting permission dialog	`this setting`	`Block` step	`Allow` step	crash-reporting pref enabled

Also checked the Light theme

Verification passed on

Brave	1.29.60 Chromium: 92.0.4515.131 (Official Build) beta (64-bit)
Revision	6b8d6c56ce21e38a72f7c4becb5abc1fa5134f29-refs/branch-heads/4515@{#1933}
OS	Ubuntu 18.04 LTS

Verified the above test plan.

Verified when crash reporting is disabled, the prompt is show.
Verified clicking settings opens brave://settings/privacy

Verified clicking Allow enables crash reporting

Verified clicking Block disables crash reporting

Verified dark mode:

Verification passed on


Brave | 1.29.60 Chromium: 92.0.4515.131 (Official Build) beta (64-bit)
-- | --
Revision | 6b8d6c56ce21e38a72f7c4becb5abc1fa5134f29-refs/branch-heads/4515@{#1933}
OS | Windows 10 OS Version 2009 (Build 19043.1165)

Verified the test plan from Implement crash reporting permission ask dialog brave-core#9508

Verified when crash reporting is disabled, the prompt is shown.
Verified clicking settings opens brave://settings/privacy

Verified clicking Allow enables crash reporting

Verified clicking Block disables crash reporting

Verified Dark mode

stephendonner · 2021-08-08T01:26:55Z

Casting QA/Test-All-Platforms label because it'd be great to have eyeballs across platforms, here, given the importance of the data.

tildelowengrimm added design A design change, especially one which needs input from the design team design/needs-mock-up needs-mockup A feature which needs design mockup to be implemented. labels Oct 25, 2018

tildelowengrimm added this to the 1.0 milestone Oct 25, 2018

tildelowengrimm mentioned this issue Oct 25, 2018

Enable Crash reporting by default for Dev and Nightly (0.63 and later) #1630

Closed

bbondy modified the milestones: 1.0, 1.x Backlog Oct 30, 2018

rebron added the priority/P4 Planned work. We expect to get to it "soon". label Nov 2, 2018

rebron modified the milestone: 1.x Backlog Feb 7, 2019

rebron removed the priority/P4 Planned work. We expect to get to it "soon". label May 5, 2020

rebron assigned karenkliu and rebron May 5, 2020

rebron added the priority/P3 The next thing for us to work on. It'll ride the trains. label May 5, 2020

karenkliu removed the design/needs-mock-up needs-mockup A feature which needs design mockup to be implemented. label Mar 24, 2021

karenkliu mentioned this issue May 6, 2021

Implement Enable Crash Reporting from brave://crashes #1596

Open

rebron added the OS/Desktop label May 12, 2021

simonhong self-assigned this Jun 18, 2021

simonhong mentioned this issue Jul 21, 2021

Implement crash reporting permission ask dialog brave/brave-core#9508

Merged

24 tasks

simonhong added QA/Yes release-notes/include labels Jul 27, 2021

simonhong closed this as completed in brave/brave-core#9508 Aug 2, 2021

simonhong added this to the 1.29.x - Nightly milestone Aug 2, 2021

stephendonner added QA/Test-Plan-Specified QA Pass-macOS QA/Test-All-Platforms labels Aug 2, 2021

btlechowski added the QA Pass-Linux label Aug 16, 2021

GeetaSarvadnya added the QA Pass-Win64 label Aug 18, 2021

This was referenced Aug 27, 2021

crash prompt dialog has both rounded and square corners - follow up to #1841 #17722

Closed

[Desktop] Release Notes for 1.29.x Release #1 #17767

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Crash reporting prompt on release channel #1841

Crash reporting prompt on release channel #1841

tildelowengrimm commented Oct 25, 2018 •

edited by karenkliu

Loading

srirambv commented Oct 25, 2018 •

edited

Loading

rebron commented May 5, 2020

iefremov commented May 5, 2020 •

edited

Loading

iefremov commented Sep 18, 2020

karenkliu commented Mar 2, 2021

simonhong commented Jul 19, 2021 •

edited

Loading

simonhong commented Jul 21, 2021

karenkliu commented Jul 21, 2021

stephendonner commented Aug 2, 2021 •

edited by GeetaSarvadnya

Loading

stephendonner commented Aug 8, 2021

Crash reporting prompt on release channel #1841

Crash reporting prompt on release channel #1841

Comments

tildelowengrimm commented Oct 25, 2018 • edited by karenkliu Loading

Description

Design

Assets

srirambv commented Oct 25, 2018 • edited Loading

rebron commented May 5, 2020

iefremov commented May 5, 2020 • edited Loading

iefremov commented Sep 18, 2020

karenkliu commented Mar 2, 2021

simonhong commented Jul 19, 2021 • edited Loading

simonhong commented Jul 21, 2021

karenkliu commented Jul 21, 2021

stephendonner commented Aug 2, 2021 • edited by GeetaSarvadnya Loading

stephendonner commented Aug 8, 2021

tildelowengrimm commented Oct 25, 2018 •

edited by karenkliu

Loading

srirambv commented Oct 25, 2018 •

edited

Loading

iefremov commented May 5, 2020 •

edited

Loading

simonhong commented Jul 19, 2021 •

edited

Loading

stephendonner commented Aug 2, 2021 •

edited by GeetaSarvadnya

Loading