Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Crash reporting by default for Dev and Nightly (0.63 and later) #1630

Closed
srirambv opened this issue Oct 16, 2018 · 10 comments · Fixed by brave/brave-core#1985
Closed

Comments

@srirambv
Copy link
Contributor

srirambv commented Oct 16, 2018

Test plan

  1. Download and install Brave (Dev or Nightly channel, which has this fix)
  2. Fresh profile
  3. Go to brave://settings/
  4. Verify Automatically send crash reports to Brave is enabled

Description

Crash reporting should be enabled by default on Dev and Nightly so that we can get reports on whats causing the crashes. This should also be informed to the user on the welcome page probably on the first page as a note or as an option at the end. Preferably on the first view of the welcome page as some users might just click skip welcome tour and might not see it if its at the end.

cc: @bbondy @rebron @kjozwiak @bsclifton

@srirambv srirambv added design A design change, especially one which needs input from the design team design/needs-mock-up needs-mockup A feature which needs design mockup to be implemented. setup/installer about-pages/welcome labels Oct 16, 2018
@srirambv srirambv added this to the 0.56.x - Beta milestone Oct 16, 2018
@tildelowengrimm
Copy link
Contributor

First run flow is a great place to put the notification. It could also go on the download page next to the download button.

@tildelowengrimm
Copy link
Contributor

Text is now live on the download pages for dev and beta, which ✅ the privacy review. We should be fine to actually turn this on now.

@tildelowengrimm tildelowengrimm removed their assignment Oct 25, 2018
@tildelowengrimm tildelowengrimm removed about-pages/welcome design A design change, especially one which needs input from the design team design/needs-mock-up needs-mockup A feature which needs design mockup to be implemented. setup/installer labels Oct 25, 2018
@tildelowengrimm
Copy link
Contributor

Prompt for release builds is in #1841.

@kjozwiak
Copy link
Member

screen shot 2018-10-25 at 2 59 12 pm

screen shot 2018-10-25 at 2 59 42 pm

@tomlowenthal should we mention but you can turn this off if you’d like. in the dev download page as well? You can still technically turn it off in dev. It might scare some users from using the dev channel? I'm not sure, might not be an issue. Just wanted to see what you thought 👍

@tildelowengrimm
Copy link
Contributor

I added it to the beta channel but not dev for two reasons. Number one, honestly was length — the dev text is already quite long. Number two was that I fully expect people using dev to go into their settings immediately after install and touch every button, switch, and knob. I very much doubt that anyone's going to compare the two pages and reach the conclusion that crash reporting can't be disabled on dev. And if folks are scared away from dev for that reason, I suspect they'd be happier on beta anyway. 🤷🏻‍♂️

@rebron
Copy link
Collaborator

rebron commented Oct 26, 2018

Total number of users for dev and for beta are running the same right now.

@bbondy
Copy link
Member

bbondy commented Oct 27, 2018

I think we'll want to run some marketing efforts to get Beta 10x the size as dev at some point.

@rebron rebron removed this from the 0.56.x - Beta milestone Oct 30, 2018
@bbondy bbondy added this to the 1.x Backlog milestone Oct 30, 2018
@rebron rebron added the priority/P3 The next thing for us to work on. It'll ride the trains. label Oct 30, 2018
@rebron rebron modified the milestone: 1.x Backlog Feb 7, 2019
@bsclifton
Copy link
Member

bsclifton commented Mar 15, 2019

Per #3729 - I verified this was never actually enabled
cc: @tomlowenthal

@simonhong simonhong self-assigned this Mar 15, 2019
@simonhong simonhong changed the title Enable Crash reporting by default for Beta and Dev Enable Crash reporting by default for Dev and Nightly Mar 18, 2019
@bsclifton bsclifton added this to the 0.64.x - Nightly milestone Mar 18, 2019
@bsclifton
Copy link
Member

@simonhong FYI - I just added a test plan (in case you wanted to verify it) 😄

@btlechowski
Copy link

btlechowski commented Mar 19, 2019

Verification passed on

Brave 0.63.14 Chromium: 73.0.3683.75 (Official Build) dev (64-bit)
Revision 909ee014fcea6828f9a610e6716145bc0b3ebf4a-refs/branch-heads/3683@{#803}
OS Windows 10 OS Build 17134.523

image

Verification passed on

Brave 0.63.15 Chromium: 73.0.3683.75 (Official Build) dev (64-bit)
Revision 909ee014fcea6828f9a610e6716145bc0b3ebf4a-refs/branch-heads/3683@{#803}
OS Linux mint

image

Verified passed with

Brave 0.63.21 Chromium: 73.0.3683.75 (Official Build) dev(64-bit)
Revision 909ee014fcea6828f9a610e6716145bc0b3ebf4a-refs/branch-heads/3683@{#803}
OS Mac OS X
Brave 0.64.8 Chromium: 73.0.3683.75 (Official Build) nightly(64-bit)
Revision 909ee014fcea6828f9a610e6716145bc0b3ebf4a-refs/branch-heads/3683@{#803}
OS Mac OS X

@bsclifton bsclifton changed the title Enable Crash reporting by default for Dev and Nightly Enable Crash reporting by default for Dev and Nightly (0.63 and later) Apr 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment