[CLOSED] Expose mode and getTokenAt() on editor

[core-ai-bot]

Issue by gruehle
Friday May 04, 2012 at 00:26 GMT
Originally opened as adobe/brackets#804

---

This is related to #803

While writing the "Inline Editor for JavaScript functions" and "Inline Image Viewer" extensions, I needed to access the "private" _codeMirror property in order to get the current mode (using getOption("mode")) and call the getTokenAt() function.

We should either expose these on Editor, or consider just making the _codeMirror property public.

[core-ai-bot]

Comment by njx
Tuesday May 08, 2012 at 18:11 GMT

---

To@peterflynn and@gruehle to talk about along with #803.

[core-ai-bot]

Comment by peterflynn
Thursday May 24, 2012 at 01:55 GMT

---

Pull #923 fixed half of this by adding an Editor.getModeForSelection() API. For the remaining half (getTokenAt()) we're still not really sure how much (if any) we should try to abstract away the CodeMirror tokenizer APIs.

[core-ai-bot]

Comment by peterflynn
Thursday Mar 28, 2013 at 23:41 GMT

---

The existing TokenUtils abstracts away getTokenAt() reasonably well, and the new 'token stream' I'm working on will do so even more cleanly. After that we may be able to close this.

[core-ai-bot]

Comment by ficristo
Thursday Dec 31, 2015 at 13:20 GMT

---

Is there still something to do here? Has "token stream" landed?

[core-ai-bot]

Comment by MarcelGerber
Friday Feb 19, 2016 at 23:21 GMT

---

I guess this can be closed now, as we've managed to achieve everything we need from our TokenUtils implementation.
Thanks for noticing,@ficristo (and yeah, it's been some time, I'm catching up with my mail again ;) )