You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Sep 6, 2021. It is now read-only.
While writing the "Inline Editor for JavaScript functions" and "Inline Image Viewer" extensions, I needed to access the "private" _codeMirror property in order to get the current mode (using getOption("mode")) and call the getTokenAt() function.
We should either expose these on Editor, or consider just making the _codeMirror property public.
The text was updated successfully, but these errors were encountered:
Pull #923 fixed half of this by adding an Editor.getModeForSelection() API. For the remaining half (getTokenAt()) we're still not really sure how much (if any) we should try to abstract away the CodeMirror tokenizer APIs.
The existing TokenUtils abstracts away getTokenAt() reasonably well, and the new 'token stream' I'm working on will do so even more cleanly. After that we may be able to close this.
I guess this can be closed now, as we've managed to achieve everything we need from our TokenUtils implementation.
Thanks for noticing, @ficristo (and yeah, it's been some time, I'm catching up with my mail again ;) )
This is related to #803
While writing the "Inline Editor for JavaScript functions" and "Inline Image Viewer" extensions, I needed to access the "private"
_codeMirror
property in order to get the current mode (usinggetOption("mode")
) and call thegetTokenAt()
function.We should either expose these on Editor, or consider just making the
_codeMirror
property public.The text was updated successfully, but these errors were encountered: