This repository has been archived by the owner on Feb 21, 2024. It is now read-only.
Feature: Add pure modeler example with esbuild + pnpm #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
i don't like this CLA stuff this is a barrier and i just needed to read stuff - im a programmer c'mon |
…mposition over Inheritance) Using Inheritance didnt inherit the constructor correctly in vsCode and typescript (it worked at runtime though) And that was the only reason why i choose inheritance
|
Thanks for your contribution! 👍 We will have a look, soon, and get back to you with further feedback. |
|
Thanks for your contribution! Appologies for the long waiting time on this one. We're not going to merge this as this PR is a little bit all over the place. It is basically an opinionated technology show-case. If we wanted to turn it into focussed examples there is at least the following aspects:
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi i made a new example which is just a basic starting point, but with esbuild.
also the sibling https://github.com/bpmn-io/bpmn-js-examples/tree/master/modeler has a pure modeler example but this one does not so i thought it would be fitting ;)