Feature: New Modeler Example with Esbuild and Typescript #183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1e85111 to
8689fc0
Compare
|
Thanks for your contribution. Appologies for the long waiting time on this one. We're not going to merge this as this PR is a little bit all over the place. It is basically an opinionated technology show-case. If we wanted to turn it into focussed examples there is at least the following aspects:
|
|
If you want to host such example yourself somewhere we're happy to link it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is basically the sibling from: bpmn-io/cmmn-js-examples#2
Strongly inspired by the other modeler https://github.com/bpmn-io/bpmn-js-examples/tree/master/modeler
About Typescript and my d.ts
Idk if https://github.com/bpmn-io/bpmn-js-examples/compare/master...mhsdesign:bpmn-js-examples:feature/esbuild-modeler?expand=1#diff-03efeee701147bbf2f822af3396516dc41895241a3cebf953a244fd74573c56c is the best practice, but its sure the only practice to get typescript/vscode-intellisense working, sure you have lovely js-docs, but they dont seem to work for inheritance (or miss some inheritance attributes?) ... even placing random js-doc annotations around (link) wont work ...