Add errors group to input output tab #435
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4b97d34 to
ddc45ea
Compare
22bc9e1 to
740ced3
Compare
|
Maybe we should squash the commits beforehand. |
740ced3 to
db1b6f1
Compare
| entries: [], | ||
|
|
||
| enabled: function(element, node) { | ||
| return is(element, 'bpmn:ServiceTask') && getBusinessObject(element).type === 'external'; |
There was a problem hiding this comment.
I wonder if we would get safer if we use internal helpers for this.
return ImplementationTypeHelper.getImplementationType(element) === 'external';db1b6f1 to
8b0cc48
Compare
|
Checked the latest artifact right now - looks and behaves as expected. ✅ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to camunda/camunda-modeler#2070
This PR adds the UI component of the
camunda:ErrorEventDefinitionelements in the properties panel, in the input/output tab.2 missing features to note :
-Copying and pasting a service task with a camunda:ErrorEventDefinition that references a bpmn:Error doesn't apply the reference on paste.
-Changing the type of a service task with camunda:ErrorEventDefninitions won't delete them, just hide the errors group in the input/output tab
Those features will be added at a later stage.
Acceptance Criteria
Definition of Done