Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement new UI component supporting camunda:errorEventDefinition for external ServiceTasks #422

Closed
5 tasks done
MaxTru opened this issue Jan 25, 2021 · 3 comments
Closed
5 tasks done
Assignees
Labels
enhancement New feature or request

Comments

@MaxTru
Copy link
Contributor

MaxTru commented Jan 25, 2021

What should we do?

CamBPM will support camunda:externalEventDefinitions for external service tasks starting with 7.15. (see issue).

Goal of this issue is, to support defining, editing and deleting camunda:externalEventDefinitions for external service tasks.

Screenshot_20210125_111248

In particular:

  • Add a new section "Errors thrown" to the "Input/Output" tab for serviceTasks with implementation==external.
  • Re-use the "list of collapsibles" UI element, we used for input and output parameters
  • The "list of collapsbile" headers shall display <errorName> (code: <errorCode>) <- <expression> (note that the expression part shall only be displayed, if an expression is defined and if the item is collapsed.
  • Fields as sketched in the UI
  • Note that some fields modify the referenced global error entity and not the camunda:errorEventDefinion per se

Why should we do it?

See overall objective camunda/camunda-modeler#2070
Child of camunda/camunda-modeler#2070

@MaxTru MaxTru added the enhancement New feature or request label Jan 25, 2021
@MaxTru MaxTru self-assigned this Jan 25, 2021
@MaxTru MaxTru added the ready Ready to be worked on label Jan 25, 2021 — with bpmn-io-tasks
@bpmn-io-tasks bpmn-io-tasks bot added in progress Currently worked on and removed ready Ready to be worked on labels Feb 12, 2021
@MaxTru
Copy link
Contributor Author

MaxTru commented Feb 15, 2021

Update to requirements:
As @andreasgeier pointed out correctly, the "Expression" should also have a validation.

@azeghers please investigate whether "must have value" or "must contain valid expression" validation is better from the user perspective.

@MaxTru MaxTru removed their assignment Feb 15, 2021
@azeghers
Copy link
Contributor

Noted 👍

@azeghers
Copy link
Contributor

Testing session with Miklas and Thorben on 2021/03/10 :

Rough recreation of test case

image

Tested in cockpit with an hardcoded ${true} throw expression, and with a boolean variable in the external task.
Both resulted in the camunda:ErrorEventDefinition being triggered, and the error path was taken.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants