Skip to content
This repository has been archived by the owner on Oct 1, 2019. It is now read-only.

bgrabow soln d09 & d10 #94

Merged
merged 72 commits into from
Dec 11, 2018
Merged

bgrabow soln d09 & d10 #94

merged 72 commits into from
Dec 11, 2018

Conversation

bgrabow
Copy link
Contributor

@bgrabow bgrabow commented Dec 11, 2018

No description provided.

@borkdude
Copy link
Owner

@bgrabow I made a small change to the test-diff script. I was surprised the test status is marked as success by CircleCI while an exception happened. Can you merge with the latest commits in master and update this PR to test (without removing the exception)?

@bgrabow
Copy link
Contributor Author

bgrabow commented Dec 11, 2018

Same exception, CI still passes.

@bgrabow
Copy link
Contributor Author

bgrabow commented Dec 11, 2018

I assume CI will skip my test case if they run slow? My day-9 clj ArrayDeque solution is pretty quick but I don't have a quick solution for cljs. If a slow test isn't going to be a problem then I will just upload the slow version. What do you suggest?

@borkdude
Copy link
Owner

@bgrabow See the notes on metadata here: https://github.com/borkdude/advent-of-cljc/#tests

@bgrabow
Copy link
Contributor Author

bgrabow commented Dec 11, 2018

Fixed the cljs compilation errors and skipped the cljs tests, thanks for the direction. CI build success is real this time!

@borkdude
Copy link
Owner

@bgrabow Can you please remove your own (test+real) input from the solution?

https://github.com/borkdude/advent-of-cljc/pull/94/files#diff-470aa1f881362bafb057de3f54b1c372R12

See the README and also this issue:

#6

I believe @mfikes found a nice solution by not giving away any hints in his code about the message in day 10 by hashing the string. Could be nice to apply here as well.

@bgrabow
Copy link
Contributor Author

bgrabow commented Dec 11, 2018

Removed the two input strings. Give me a little time to figure out how to remove the letter patterns.

@bgrabow
Copy link
Contributor Author

bgrabow commented Dec 11, 2018

Removed the letter patterns. Thanks for the hash suggestion, and sorry for committing the input in the first place!

@borkdude borkdude merged commit b72ee8f into borkdude:master Dec 11, 2018
transducer pushed a commit to transducer/advent-of-cljc that referenced this pull request Dec 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants