Fix This instantiation #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Still need to add a test. |
|
Let's land #55 before this since then I can update the tests accordingly. |
dellaert
approved these changes
Mar 24, 2021
| class_instantiated_methods = list(original.methods) | ||
| self.properties = list(original.properties) | ||
| else: | ||
| if original.template: |
There was a problem hiding this comment.
Now that you know what this code does, and logic below, add a comment here to that effect.
| self.name = instantiate_name( | ||
| original.name, instantiations) if not new_name else new_name | ||
|
|
||
| # Check for typenames if templated. |
| Instantiate the class constructors. | ||
|
|
||
| Args: | ||
| typenames: List of template types to instantiate. |
| Instantiate static methods in the class. | ||
|
|
||
| Args: | ||
| typenames: List of template types to instantiate. |
| """ | ||
| This function only instantiates class templates in the methods. | ||
| Template methods are instantiated in InstantiatedMethod in the second | ||
| round. | ||
|
|
||
| Args: | ||
| typenames: List of template types to instantiate. | ||
| """ |
|
|
||
| Args: | ||
| typenames: List of template types to instantiate. | ||
| """ |
|
Honestly, there is so much more documentation left to be done. I'll add more. |
|
Added the test, will add docs after I get some physical activity. |
|
Added docs. Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can now use
Thiswith non-templated classes as well.I am not sure if that is what @ProfFan was hinting at with the last task item in borglab/gtsam#407 but it works for both templated an non-templated classes. 🙂