Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor III - Return of the Test Suite #55

Merged
merged 8 commits into from
Mar 24, 2021
Merged

Refactor III - Return of the Test Suite #55

merged 8 commits into from
Mar 24, 2021

Conversation

varunagrawal
Copy link
Collaborator

  • Restructured test files with a dedicated fixtures directory.
  • Broke down the tests to smaller bits each testing a dedicated functionality, should help in debugging.
  • Some clean up and formatting.

This is a big PR (but it only deals with 1 thing - testing!!) so please take your time with it.

@varunagrawal varunagrawal self-assigned this Mar 24, 2021
@varunagrawal varunagrawal mentioned this pull request Mar 24, 2021
Merged
ProfFan
ProfFan approved these changes Mar 24, 2021
View reviewed changes
Copy link
Collaborator

@ProfFan ProfFan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@varunagrawal varunagrawal merged commit d0f8a39 into master Mar 24, 2021
@varunagrawal varunagrawal deleted the feature/refactor3 branch March 24, 2021 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ProfFan ProfFan ProfFan approved these changes

@dellaert dellaert dellaert approved these changes

Assignees

@varunagrawal varunagrawal

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@varunagrawal @ProfFan @dellaert