remove empty shadowed_segments lists, fixes #5275 #5614
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@enkore can you please try & review? |
|
I notice that |
6f184df to
c3a3f34
Compare
Codecov Report
@@ Coverage Diff @@
## master #5614 +/- ##
==========================================
- Coverage 82.82% 82.55% -0.27%
==========================================
Files 38 38
Lines 10154 10062 -92
Branches 1682 1674 -8
==========================================
- Hits 8410 8307 -103
- Misses 1238 1246 +8
- Partials 506 509 +3
Continue to review full report at Codecov.
|
|
rebased on current master. |
|
@timmc good catch! we will have to check whether there is a bug or that has to be like that, not sure yet. |
c7f0aac to
c3a3f34
Compare
|
I'll merge this soon, but it would be good if there was some more independent review. |
also: - add test for removed empty shadowed_segments list - add some comments - add repo_dump test debug tool
c3a3f34 to
6f00b02
Compare
ThomasWaldmann
added a commit
to ThomasWaldmann/borg
that referenced
this pull request
Feb 15, 2021
also: - add test for removed empty shadowed_segments list - add some comments - add repo_dump test debug tool note: this is the backport of borgbackup#5614 to 1.1-maint - it needed some adaptions to fit into 1.1-maint: 1.1-maint always compacts when committing and does not persist shadow_index, so the tests are a bit different
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
also: