Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

check empty segments lists in shadow_index #5275

Closed
ThomasWaldmann opened this issue Jul 28, 2020 · 0 comments
Closed

check empty segments lists in shadow_index #5275

ThomasWaldmann opened this issue Jul 28, 2020 · 0 comments
Assignees
@ThomasWaldmann
Milestone
hydrogen-b2

Comments

@ThomasWaldmann
Copy link
Member

while doing #5263, i tried to remove empty segments lists from the shadow_index, but then tests failed.

as they maybe shouldn't remain in there forever, this needs checking again
@ThomasWaldmann ThomasWaldmann added this to the hydrogen-alpha10 milestone Jul 28, 2020
@ThomasWaldmann ThomasWaldmann self-assigned this Jan 6, 2021
ThomasWaldmann added a commit to ThomasWaldmann/borg that referenced this issue Jan 6, 2021
@ThomasWaldmann
remove empty shadowed_segments lists, fixes borgbackup#5275
6f184df 
also:
- add test for removed empty shadowed_segments list
- add some comments
- add repo_dump test debug tool
ThomasWaldmann added a commit to ThomasWaldmann/borg that referenced this issue Jan 18, 2021
@ThomasWaldmann
remove empty shadowed_segments lists, fixes borgbackup#5275
c3a3f34 
also:
- add test for removed empty shadowed_segments list
- add some comments
- add repo_dump test debug tool
ThomasWaldmann added a commit that referenced this issue Jan 29, 2021
@ThomasWaldmann
Merge pull request #5614 from ThomasWaldmann/remove-empty-shadowed-se…
e3d8b7c 
…gments-list-master

remove empty shadowed_segments lists, fixes #5275
ThomasWaldmann added a commit to ThomasWaldmann/borg that referenced this issue Feb 15, 2021
@ThomasWaldmann
remove empty shadowed_segments lists, fixes borgbackup#5275
e9c1c40 
also:
- add test for removed empty shadowed_segments list
- add some comments
- add repo_dump test debug tool

note: this is the backport of borgbackup#5614 to 1.1-maint - it needed some adaptions to fit into 1.1-maint:

1.1-maint always compacts when committing and does not persist shadow_index, so the tests are a bit different
@ghost ghost mentioned this issue Aug 26, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ThomasWaldmann ThomasWaldmann

Labels
None yet
Projects
None yet
Milestone
hydrogen-b2
Development

No branches or pull requests
1 participant
@ThomasWaldmann