ENH: add action to get feature lengths #164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChristosMatzoros
approved these changes
May 14, 2024
There was a problem hiding this comment.
Dear @misialq,
The code and tests are simple and clean. I conditionally reviewed this PR based on the related PR in q2-types that introduces the SequenceCharacteristics type. I executed the get-feature-lengths action using both the provided dataset and my own dataset. To verify the results, I manually extracted the number of total characters per FASTA file from the initial file. The feature lengths matched, and all tests passed successfully.
Feel free to merge once the dependency is resolved!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #163.
Depends on qiime2/q2-types#326.
To test use any dereplicated MAGs artifact (
FeatureData[MAG]), e.g. mags-dereplicated.qza.zip