feat: static settings page #570

lily-de · 2025-01-10T01:05:24Z

PR Summary: Implement New Static Settings Page

Author's note: this change is feature-flag gated by npm environment and will only appear if you're running the electron app (npm start)

This pull request introduces a new static settings page to the Goose project, providing users with an interface to manage application preferences and configurations.

Screen.Recording.2025-01-10.at.11.18.07.AM.mov

How It Works

Page Structure:
- The settings page is implemented as a React component located in ui/desktop/src/components/settings/Settings.tsx.
- Accessible through the /settings route, added to the application's routing configuration.
- The page dynamically loads and manages settings through React state.
Core Functionality:
- Sectioned Layout: Settings are grouped into organized sections with headers for better navigation, implemented using SectionHeader.tsx.
- Editable Items: Each setting is represented by SettingItem.tsx, which allows toggling options or updating values.
- Key Management: API keys or similar fields are managed with the KeyItem.tsx component, supporting edits.
- Dialogs: @radix-ui/react-dialog is used to display modals for advanced settings or confirmations.
- Adding Models or Extensions: Users can add a new model or extension by typing strings into a dialog. Note: This is a placeholder implementation, and the final version may require validation, additional metadata, or backend integration to reflect real-world usage.
- Reseting to default settings: Can reset to some hard-coded default state.
State Persistence:
- The page uses localStorage to save and retrieve user preferences, ensuring settings persist across sessions (persists with cmd+N or if you close the electron app and re-run npm start).
- Example:
  - User settings are saved with localStorage.setItem('user_settings', JSON.stringify(settings)).
  - Retrieved during initialization using localStorage.getItem('user_settings').
- Limitations: This implementation does not sync settings across devices or browsers and relies entirely on local storage. Also will force all session windows to the same settings (e.g. open 2nd window -> change settings -> window 1 will now have those settings too).

Missing or Incomplete Functionality

Backend Integration: Currently, settings are stored only in localStorage. A backend solution is required for cross-device synchronization or user account integration.
Deletion and Editing of Models and Extensions: Currently you can only add.
Validation: Limited validation exists for certain fields like API keys, which may require further improvements for production use.
Advanced Features: Import/export settings.

Key Code Changes

Routing:
- Added the /settings route to the app's routing configuration.
Components:
- Introduced new components:
  - Settings: Main page logic and rendering.
  - SettingItem: UI for individual settings.
  - KeyItem: Specialized input for key-based settings.
  - SectionHeader: Organizational headers for grouped settings.
Dependencies:
- Integrated @radix-ui/react-dialog for modal dialogs.

Checklist

Implemented static settings page and core functionality.
Verified settings persist across sessions using localStorage.
Backend persistence is not implemented.
Validation for fields requires enhancement.

Copilot reviewed 6 out of 20 changed files in this pull request and generated no comments.

Files not reviewed (14)

ui/desktop/package.json: Language not supported
ui/desktop/src/ChatWindow.tsx: Evaluated as low risk
ui/desktop/src/components/MoreMenu.tsx: Evaluated as low risk
ui/desktop/src/utils/cn.ts: Evaluated as low risk
ui/desktop/src/components/settings/types.ts: Evaluated as low risk
ui/desktop/src/components/settings/Settings.tsx: Evaluated as low risk
ui/desktop/src/components/ui/Tooltip.tsx: Evaluated as low risk
ui/desktop/src/components/settings/SettingsSection.tsx: Evaluated as low risk
ui/desktop/src/components/settings/SectionHeader.tsx: Evaluated as low risk
ui/desktop/src/components/settings/ToggleableItem.tsx: Evaluated as low risk
ui/desktop/src/components/settings/SettingItem.tsx: Evaluated as low risk
ui/desktop/src/components/settings/modals/RevealKeysDialog.tsx: Evaluated as low risk
ui/desktop/src/components/settings/modals/AddModelDialog.tsx: Evaluated as low risk
ui/desktop/src/components/settings/modals/BaseDialog.tsx: Evaluated as low risk

Comments suppressed due to low confidence (1)

ui/desktop/src/components/ui/toast.tsx:11

The class name animate-in should be animate-in-fade-in-slide-in-from-bottom-5.

animate-in fade-in slide-in-from-bottom-5

ui/desktop/src/utils/cn.ts

ui/desktop/src/components/ui/dialog.tsx

Kvadratni · 2025-01-10T05:18:22Z

ui/desktop/src/components/settings/KeyItem.tsx

ui/desktop/src/components/settings/Settings.tsx

alexhancock

This is great we should merge it.

Before we do, is there a way we can "feature flag" it so it only shows up when running from source code, and not in the deployed app sent to MSC? I just wouldn't want to ship it to real users before the settings actually take effect.

lily-de · 2025-01-10T19:17:45Z

This is great we should merge it.

Before we do, is there a way we can "feature flag" it so it only shows up when running from source code, and not in the deployed app sent to MSC? I just wouldn't want to ship it to real users before the settings actually take effect.

yeah great idea -- was also thinking maybe the settings page stuff can be merged to some intermediary branch before merging to v1.0 but might end up messier

github-actions · 2025-01-10T19:29:58Z

Desktop App for this PR

The following build is available for testing:

📱 macOS Desktop App (Universal, signed)

The app is signed and notarized for macOS. After downloading, unzip the file and drag the Goose.app to your Applications folder.

This link is provided by nightly.link and will work even if you're not logged into GitHub.

github-actions · 2025-01-10T20:09:44Z

Desktop App for this PR

The following build is available for testing:

📱 macOS Desktop App (Universal, signed)

The app is signed and notarized for macOS. After downloading, unzip the file and drag the Goose.app to your Applications folder.

This link is provided by nightly.link and will work even if you're not logged into GitHub.

github-actions · 2025-01-10T20:39:15Z

Desktop App for this PR

The following build is available for testing:

📱 macOS Desktop App (Universal, signed)

The app is signed and notarized for macOS. After downloading, unzip the file and drag the Goose.app to your Applications folder.

This link is provided by nightly.link and will work even if you're not logged into GitHub.

github-actions · 2025-01-13T19:06:06Z

Desktop App for this PR

The following build is available for testing:

📱 macOS Desktop App (Universal, signed)

The app is signed and notarized for macOS. After downloading, unzip the file and drag the Goose.app to your Applications folder.

This link is provided by nightly.link and will work even if you're not logged into GitHub.

- Fix import conflicts from Settings component move - Update electron API type definitions - Standardize createChatWindow calls with empty string param - Remove duplicate imports

github-actions · 2025-01-13T20:18:04Z

Desktop App for this PR

The following build is available for testing:

📱 macOS Desktop App (Universal, signed)

The app is signed and notarized for macOS. After downloading, unzip the file and drag the Goose.app to your Applications folder.

This link is provided by nightly.link and will work even if you're not logged into GitHub.

github-actions · 2025-01-13T20:56:58Z

Desktop App for this PR

The following build is available for testing:

📱 macOS Desktop App (Universal, signed)

The app is signed and notarized for macOS. After downloading, unzip the file and drag the Goose.app to your Applications folder.

This link is provided by nightly.link and will work even if you're not logged into GitHub.

* v1.0: feat: static settings page (#570) styles: adding arcade styles and cash sans (#581) feat: quick spinner while loading tokenizers (#573) Add timeout middleware for clients (#572) chore: remove unused old setup for CLI (#574) feat: env and secrets configuration for mcp server (#565) Add Databricks moderation (#540) feat: add pagination support for tools/list and resources/list (#566) Add resource capabilties to MCP servers that use it (#576) Add goose versions to the UI (#526) fix: Set stdin to null in shell/bash tools (#568) Add base moderation to Providers (#513) feat: set process_group(0) on stdio systems to avoid ctrl-c handling (#567) feat: read only active resources in the agent loop (#560)

lily-de changed the base branch from main to v1.0 January 10, 2025 01:05

lily-de changed the title ~~feature: static settings page~~ feat: static settings page Jan 10, 2025

lily-de marked this pull request as ready for review January 10, 2025 01:17

lily-de requested review from alexhancock, michaelneale and Copilot January 10, 2025 01:30

Copilot AI reviewed Jan 10, 2025

View reviewed changes

michaelneale reviewed Jan 10, 2025

View reviewed changes

ui/desktop/src/utils/cn.ts Outdated Show resolved Hide resolved

michaelneale reviewed Jan 10, 2025

View reviewed changes

ui/desktop/src/components/ui/dialog.tsx Outdated Show resolved Hide resolved

alexhancock approved these changes Jan 10, 2025

View reviewed changes

ui/desktop/src/components/settings/KeyItem.tsx Outdated Show resolved Hide resolved

alexhancock reviewed Jan 10, 2025

View reviewed changes

ui/desktop/src/components/settings/Settings.tsx Outdated Show resolved Hide resolved

alexhancock self-requested a review January 10, 2025 16:38

alexhancock reviewed Jan 10, 2025

View reviewed changes

lily-de force-pushed the ldelalande/settings-set-up branch from b90ecda to cf7bdc4 Compare January 13, 2025 18:57

lily-de added 10 commits January 13, 2025 11:46

fix conflicts

01d4464

move settings file

50886d5

fix conflicts

569d663

fix conflicts

4be0c32

fix dialogue popups

785d8cc

working static state with persisting changes

4f9899c

fix broken buttons

471c4fa

remove add extension

4f2570d

merge agent version changes with settings page changes

5fb5cfb

rename dialog and update icons

c789039

lily-de added 7 commits January 13, 2025 11:48

import showToast

15c44f4

remove shadcn-ui

7d618d2

remove accidentally deleted version menu

08d5656

fix conflicts

6261c66

fix: resolve merge conflicts in ChatWindow and MoreMenu

1e301c8

- Fix import conflicts from Settings component move - Update electron API type definitions - Standardize createChatWindow calls with empty string param - Remove duplicate imports

fix conflicts

cd5c116

fix conflicts

6276f87

lily-de force-pushed the ldelalande/settings-set-up branch from da6a5b8 to 6276f87 Compare January 13, 2025 19:50

lily-de added 4 commits January 13, 2025 11:55

force providers to be what is on v1.0 branch

9282730

fix settings

203aec7

remove settings2

53c23c6

rebase hell fix

b4743e2

fix moremenu to be what is on 1.0 branch

fab4212

lily-de merged commit bf65a7d into v1.0 Jan 13, 2025
6 checks passed

lily-de deleted the ldelalande/settings-set-up branch January 13, 2025 21:04

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: static settings page #570

feat: static settings page #570

lily-de commented Jan 10, 2025 •

edited

Loading

Kvadratni commented Jan 10, 2025

alexhancock left a comment

lily-de commented Jan 10, 2025 •

edited

Loading

github-actions bot commented Jan 10, 2025

github-actions bot commented Jan 10, 2025

github-actions bot commented Jan 10, 2025

github-actions bot commented Jan 13, 2025

github-actions bot commented Jan 13, 2025

github-actions bot commented Jan 13, 2025

feat: static settings page #570

feat: static settings page #570

Conversation

lily-de commented Jan 10, 2025 • edited Loading

PR Summary: Implement New Static Settings Page

How It Works

Missing or Incomplete Functionality

Key Code Changes

Checklist

Choose a reason for hiding this comment

Kvadratni commented Jan 10, 2025

alexhancock left a comment

Choose a reason for hiding this comment

lily-de commented Jan 10, 2025 • edited Loading

github-actions bot commented Jan 10, 2025

Desktop App for this PR

github-actions bot commented Jan 10, 2025

Desktop App for this PR

github-actions bot commented Jan 10, 2025

Desktop App for this PR

github-actions bot commented Jan 13, 2025

Desktop App for this PR

github-actions bot commented Jan 13, 2025

Desktop App for this PR

github-actions bot commented Jan 13, 2025

Desktop App for this PR

lily-de commented Jan 10, 2025 •

edited

Loading

lily-de commented Jan 10, 2025 •

edited

Loading