Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: set process_group(0) on stdio systems to avoid ctrl-c handling #567

Merged
merged 2 commits into from
Jan 10, 2025

Conversation

kalvinnchau
Copy link
Collaborator

when you ctrl-c from a goose session the ctrl-c signal is propagated to the child processes, set a different process_group to avoid that

@kalvinnchau kalvinnchau requested a review from baxen January 9, 2025 23:52
Copy link
Collaborator

@baxen baxen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

crates/mcp-client/src/transport/stdio.rs Show resolved Hide resolved
Copy link

Desktop App for this PR

The following build is available for testing:

The app is signed and notarized for macOS. After downloading, unzip the file and drag the Goose.app to your Applications folder.

This link is provided by nightly.link and will work even if you're not logged into GitHub.

@kalvinnchau kalvinnchau merged commit 2b56d48 into v1.0 Jan 10, 2025
6 checks passed
@kalvinnchau kalvinnchau deleted the kalvin/stdio-process-group branch January 10, 2025 00:17
michaelneale added a commit that referenced this pull request Jan 14, 2025
* v1.0:
  feat: static settings page (#570)
  styles: adding arcade styles and cash sans (#581)
  feat: quick spinner while loading tokenizers (#573)
  Add timeout middleware for clients (#572)
  chore: remove unused old setup for CLI  (#574)
  feat: env and secrets configuration for mcp server (#565)
  Add Databricks moderation (#540)
  feat: add pagination support for tools/list and resources/list (#566)
  Add resource capabilties to MCP servers that use it (#576)
  Add goose versions to the UI (#526)
  fix: Set stdin to null in shell/bash tools (#568)
  Add base moderation to Providers (#513)
  feat: set process_group(0) on stdio systems to avoid ctrl-c handling (#567)
  feat: read only active resources in the agent loop (#560)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants