-
Notifications
You must be signed in to change notification settings - Fork 427
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add bedrock provider #1069
Merged
Merged
+487
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tokio's runtime panics on single threaded tests.
…tion to truncate_agent tests
salman1993
reviewed
Feb 5, 2025
salman1993
approved these changes
Feb 5, 2025
@ahau-square Seems like this PR misses this commit 06d396f, could you cherry-pick that one as well please? |
michaelneale
added a commit
that referenced
this pull request
Feb 6, 2025
* main: Respect the terminal emulator's base colors (#1098) fix: add fallback sans-serif font to desktop app (#982) feat: add bedrock provider (#1069) feat: removed minHeight (#938) fix: add logs for goose run (#1085) docs: add langfuse observability guide (#1047) docs: updated bluesky link (#1078) docs: jetbrains tutorial (#1074) docs: add simple docs link (#1077) fix: apply cache control correctly to tools (#1071) fix: show default value when adding new one (#1057) fix it to use env vars if available (#1063) docs site: add PR previews (#865) chore: Better typing for preload.ts (#1055) fix: Allow port 443 to be used with https (ollama provider) (#1052)
Acumen-Desktop
pushed a commit
to Acumen-Desktop/goose
that referenced
this pull request
Feb 7, 2025
Co-authored-by: Burak Varlı <unexge@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds bedrock as a provider. As there are many possible ways to auth to aws, including:
AWS_ACCESS_KEY_ID
,AWS_ACCESS_KEY
, andAWS_REGION
explicitly as env varsAWS_PROFILE
as env varwe do not enforce any required vars to accommodate these multiple auth paths. This PR does not include modifications to the UI to enable Bedrock. This is tested / working for the CLI experience.