Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add bedrock provider #1069

Merged
merged 15 commits into from
Feb 5, 2025
Merged

feat: add bedrock provider #1069

merged 15 commits into from
Feb 5, 2025

Conversation

ahau-square
Copy link
Collaborator

@ahau-square ahau-square commented Feb 4, 2025

Adds bedrock as a provider. As there are many possible ways to auth to aws, including:

  • setting AWS_ACCESS_KEY_ID, AWS_ACCESS_KEY, and AWS_REGION explicitly as env vars
  • setting AWS_PROFILE as env var
  • working config in ~/.aws/credentials

we do not enforce any required vars to accommodate these multiple auth paths. This PR does not include modifications to the UI to enable Bedrock. This is tested / working for the CLI experience.

image

@unexge
Copy link
Contributor

unexge commented Feb 5, 2025

@ahau-square Seems like this PR misses this commit 06d396f, could you cherry-pick that one as well please?

@ahau-square ahau-square merged commit b4b213b into main Feb 5, 2025
4 checks passed
@ahau-square ahau-square deleted the add-bedrock-provider branch February 5, 2025 22:06
michaelneale added a commit that referenced this pull request Feb 6, 2025
* main:
  Respect the terminal emulator's base colors (#1098)
  fix: add fallback sans-serif font to desktop app (#982)
  feat: add bedrock provider (#1069)
  feat: removed minHeight (#938)
  fix: add logs for goose run (#1085)
  docs: add langfuse observability guide (#1047)
  docs: updated bluesky link (#1078)
  docs: jetbrains tutorial (#1074)
  docs: add simple docs link (#1077)
  fix: apply cache control correctly to tools (#1071)
  fix: show default value when adding new one (#1057)
  fix it to use env vars if available (#1063)
  docs site: add PR previews (#865)
  chore: Better typing for preload.ts (#1055)
  fix: Allow port 443 to be used with https (ollama provider) (#1052)
Acumen-Desktop pushed a commit to Acumen-Desktop/goose that referenced this pull request Feb 7, 2025
Co-authored-by: Burak Varlı <unexge@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants