fix: Allow port 443 to be used with https (ollama provider) #1052
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Per Url docs port() will return None if the scheme is https, even if the port is explicitly provided. This causes the port to always be set to 11434 when trying to use https on 443. This change will: - use 443 for https by default - use 11434 for http be default - always use the port provided
|
@beetlebugorg nice - I think this will be fine. It does mean remote has to be on one of those 2 ports though? is that ok with you? |
michaelneale
approved these changes
Feb 4, 2025
|
You can set any remote port with this change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview:
With this change I am able to use Goose with Ollama over https on 443, before this change it would always use port 11434 even if the scheme was https.
Findings:
Per Url docs port() will return None if the scheme is https, even if the port is explicitly provided. This causes the port to always be set to 11434 when trying to use https on 443.
This change will: