Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unescape values correctly #209

Closed
wants to merge 1 commit into from
Closed

Unescape values correctly #209

wants to merge 1 commit into from

Conversation

sorah
Copy link
Contributor

@sorah sorah commented Sep 7, 2015

ugly but fixes #207

@sorah
Copy link
Contributor Author

sorah commented Sep 7, 2015

I guess there are still remaining corner cases...

@sorah
Copy link
Contributor Author

sorah commented Sep 7, 2015

rubocop fails... I'll fix later

@bkeepers
Copy link
Owner

Thanks for the pull request! Sorry for the delay in responding. Would you be interested in merging master and fixing the merge conflicts?

@bkeepers
Copy link
Owner

Actually, it looks like this is fixed by #222

@bkeepers bkeepers closed this Jan 14, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Some escaped '$' characters are not unescaped
2 participants
@sorah @bkeepers