Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some escaped '$' characters are not unescaped #207

Closed
bkeepers opened this issue Aug 21, 2015 · 1 comment
Closed

Some escaped '$' characters are not unescaped #207

bkeepers opened this issue Aug 21, 2015 · 1 comment

Comments

@bkeepers
Copy link
Owner

Reported by @BeattieM in #203, there are a few instances where escaped $ doesn't get unescaped:

FOO="bar\$"
FOO="\$\$"
sorah added a commit to sorah/dotenv that referenced this issue Sep 7, 2015
@sorah
Unescape correctly
16c9932 
ugly but fixes bkeepers#207
@sorah sorah mentioned this issue Sep 7, 2015
Closed
sorah added a commit to sorah/dotenv that referenced this issue Sep 7, 2015
@sorah
Unescape correctly
b76eedc 
ugly but fixes bkeepers#207
@gautam-ndk
Copy link
Contributor

I hope this pull request #222 fixes the issue

bkeepers added a commit that referenced this issue Dec 2, 2015
@bkeepers
Merge pull request #222 from dhunnapotha/fix_proper_escaping_of_dolla…
80e8a2d 
…r_v2

Fix for #207, Some escaped '$' characters are not unescaped
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Unescape values correctly sorah/dotenv
2 participants
@bkeepers @gautam-ndk