bugfix and rename mergeIndices() #2772
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bkaradzic
reviewed
Apr 18, 2022
| @@ -65,15 +65,13 @@ class ExampleBunnyLOD : public entry::AppI | |||
| } | |||
| } | |||
|
|
|||
| static void mergeIndices(uint32_t* _indices, uint32_t _num) | |||
| static void rearrangeIndices(uint32_t* _indices, uint32_t _num) | |||
There was a problem hiding this comment.
Common term is usually remap so remapIndices?
mipek
pushed a commit
to mipek/bgfx
that referenced
this pull request
Mar 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sorry, there is still a bug in #2769 . Fixed it.
And rename mergeIndices() to rearrangeIndices() .
The details about
rearrangeIndices():The original indices are
If
bgfx:weldVertices()merge vertex 3 to 1, an 4 to 2 , the indices would berearrangeIndices()rearrange these indices to(5 to 3, 6 to 4)