New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bugfix : example 42 #2769

Merged

bkaradzic merged 1 commit into bkaradzic:master from cloudwu:fixex42

Apr 15, 2022

Contributor

cloudwu commented Apr 15, 2022

Fix a bug in array_push
I found bgfx::weldVertices is not equivalent to my orignal findDuplicateVertices. ( Replaced in Improve example 42 #2156) , so an additional transformation (mergeIndices) needed.


          bugfix : weldVert and array_push

348ccda

cloudwu requested a review from bkaradzic as a code owner

April 15, 2022 09:57

bkaradzic merged commit cae7c83 into bkaradzic:master

cloudwu deleted the fixex42 branch

April 18, 2022 07:33

cloudwu mentioned this pull request

bugfix and rename mergeIndices() #2772

Merged

mipek pushed a commit to mipek/bgfx that referenced this pull request


          bugfix : weldVert and array_push (bkaradzic#2769)

d56b608

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet