Fix crash on window minimize on vulkan renderer. #2204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On some platforms (Windows) the framebuffer size becomes 0x0 when the window is minimized. This leads to a validation error and subsequently crashes. This change correctly cleans up semaphores and the swapchain.
rozgo
pushed a commit
to VertexStudio/bgfx
that referenced
this pull request
Aug 14, 2020
On some platforms (Windows) the framebuffer size becomes 0x0 when the window is minimized. This leads to a validation error and subsequently crashes. This change correctly cleans up semaphores and the swapchain.
pigpigyyy
added a commit
to pigpigyyy/bgfx
that referenced
this pull request
Mar 11, 2021
* master: (21 commits) Improves handling of window resizes on vulkan (avoids crashes) (bkaradzic#2123) Fix crash on window minimize on vulkan renderer (bkaradzic#2204) Fix X11 flicker when window is being resized (bkaradzic#2203) Updated spirv-cross. Updated spirv-tools. Updated glslang. Updated ImGui. Cleanup. Fixed docs. Fixed issue bkaradzic#2201. Updated version number. Cleanup. OpenGL: Disable scissor testing while blitting framebuffers when MSAA is enabled (bkaradzic#2200) Updating xcode config. (bkaradzic#2198) Updated glslang. shaderc: Disabled warnings. Updated spirv-cross. Updated spirv-tools. Updated spirv-headers. Updated vulkan headers. ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On some platforms (Windows) the framebuffer size becomes 0x0 when
the window is minimized. This leads to a validation error and
subsequently crashes.
This change correctly cleans up semaphores and the swapchain.