-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PM-2903] fix : don't set pin if not provided #5769
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thank you for your contribution! We've added this to our internal Community PR board for review. |
bitwarden-bot
changed the title
fix : don't set pin if not provided
[PM-2903] fix : don't set pin if not provided
Jul 9, 2023
1 task
Hi @djsmith85 , this has been open for some time. Let me know if i need to do anything. |
navneetbz
approved these changes
Sep 23, 2023
eliykat
previously approved these changes
Oct 17, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fix! I've passed on to our QA team to verify before merging.
coroiu
approved these changes
Nov 13, 2023
BlackDex
pushed a commit
to BlackDex/bitwarden-clients
that referenced
this pull request
Nov 21, 2023
Co-authored-by: Thomas Rittson <31796059+eliykat@users.noreply.github.com> Co-authored-by: Thomas Rittson <trittson@bitwarden.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Objective
We don't want to set a pin when a user doesn't provide one. This PR addresses #5726
Code changes
When the pin is not given, the modal gets closed but the remaining code is getting executed. So an invalid pin was getting set. Just
return
from submit function if the pin is not given.Before
before.webm
After
after.webm
Before you submit