Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't allow establishing 0 length PINs by accident #5726

Closed
1 task done
jidanni opened this issue Jul 3, 2023 · 7 comments · Fixed by #5769
Closed
1 task done

Don't allow establishing 0 length PINs by accident #5726

jidanni opened this issue Jul 3, 2023 · 7 comments · Fixed by #5769
Labels

Comments

@jidanni
Copy link

jidanni commented Jul 3, 2023

Steps To Reproduce

They said https://community.bitwarden.com/t/dont-allow-establishing-0-length-pins-by-accident/55846 is a bug.

Expected Result

Please see the above URL.

Actual Result

Please see the above URL.

Screenshots or Videos

Please see the above URL.

Additional Context

No response

Operating System

Linux

Operating System Version

No response

Web Browser

Chrome

Browser Version

No response

Build Version

Newest on Chrome store.

Issue Tracking Info

  • I understand that work is tracked outside of Github. A PR will be linked to this issue should one be opened to address it, but Bitwarden doesn't use fields like "assigned", "milestone", or "project" to track progress.
@jidanni jidanni added browser Browser Extension bug labels Jul 3, 2023
@SergeantConfused
Copy link

Hi @jidanni,

Thank you for your report. I was able to reproduce this and have flagged it to our engineering team.

If you wish to add any further information/screenshots/recordings etc., please feel free to do so at any time - our engineering team will be happy to review these.

Thank you again,

@arnabrahman
Copy link
Contributor

@SergeantConfused By reproducing the bug, did you mean this? I didn't type a pin & pressed ok. And when I click Lock now, it shows me this, which is unexpected as I didn't give a pin. If this is the issue, then I can work on this.
Screenshot from 2023-07-09 22-23-11

@jidanni
Copy link
Author

jidanni commented Jul 11, 2023

Yes. Users can accidentally create null pins that can never be used.

@arnabrahman
Copy link
Contributor

arnabrahman commented Jul 17, 2023

I have opened a PR to fix this.

@SaunakNandi
Copy link

Hi Newbie here, Does this issue still exist?

@targatonica
Copy link

Hi, is this issue still available?

@jidanni
Copy link
Author

jidanni commented Oct 9, 2023

I don't know if the problem still exists, because my computer is not at home right now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants