-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PM-7105][PM-7242][PM-16256] Remove v1 code for Tab/Vault Part 2 #12516
Conversation
Fixed Issues
|
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## main #12516 +/- ##
==========================================
+ Coverage 33.74% 34.25% +0.51%
==========================================
Files 2918 2899 -19
Lines 90994 89613 -1381
Branches 17200 16830 -370
==========================================
- Hits 30703 30700 -3
+ Misses 57891 56513 -1378
Partials 2400 2400 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the cleanup! Looks good to go for Vault owned code!
…t/pm-16256/remove-v1-vault-components
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-16256
📔 Objective
With #12485 I already removed the conditional routing to the new Vault UI based on the ExtensionRefresh-feature flag. This PR aims to continue the removal of all conditional routings for vault-owned components, but also goes ahead and deletes all the now unused v1 Vault code.
Removing the conditional routing is needed, as the new Vault UI would show, but once a user clicks on edit or creates a new item, they would be presented with the old Add/Edit UI.
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:
) or similar for great changes:memo:
) or ℹ️ (:information_source:
) for notes or general info:question:
) for questions:thinking:
) or 💭 (:thought_balloon:
) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:
) for suggestions / improvements:x:
) or:warning:
) for more significant problems or concerns needing attention:seedling:
) or ♻️ (:recycle:
) for future improvements or indications of technical debt:pick:
) for minor or nitpick changes