Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-7100] Remove conditional routing for extension refresh #12485

Merged

Conversation

djsmith85
Copy link
Contributor

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-7100

📔 Objective

This is partial work of https://bitwarden.atlassian.net/browse/PM-7100 to remove the conditional routing of the extension refresh. This is needed to unblock #12345 and #12342 as they currently don't display show the header/nav-footer thus not showing the scrollable part (generator history, further settings on Send)

Asking for a review from the 2 of you, as this involves routing code from Auth (tabs/current -> tabs/vault) and removing the conditional routing of the Vault page.

Further clean-up of the v1 components will be followed up by your individual teams.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

Copy link
Member

@shane-melton shane-melton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for getting this started already!

Copy link

codecov bot commented Dec 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 33.56%. Comparing base (0f9e18b) to head (d7ea021).
Report is 14 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #12485   +/-   ##
=======================================
  Coverage   33.56%   33.56%           
=======================================
  Files        2926     2925    -1     
  Lines       91527    91518    -9     
  Branches    17395    17395           
=======================================
  Hits        30721    30721           
+ Misses      58392    58383    -9     
  Partials     2414     2414           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@JaredSnider-Bitwarden JaredSnider-Bitwarden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@djsmith85 djsmith85 merged commit acd3ab0 into main Dec 20, 2024
25 of 27 checks passed
@djsmith85 djsmith85 deleted the vault/pm-7100/remove-conditional-routing-for-extension-refresh branch December 20, 2024 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants