-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add compare-sections
to gdb scripts
#703
Open
lmbollen
wants to merge
13
commits into
staging
Choose a base branch
from
lucas/compare-sections
base: staging
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5212457
to
e939942
Compare
martijnbastiaan
approved these changes
Jan 13, 2025
@@ -14,6 +14,9 @@ break smoltcp_client::gdb_panic | |||
target extended-remote :3333 | |||
load | |||
|
|||
#Verify whether we transfered the binary correctly |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
#Verify whether we transfered the binary correctly | |
# Verify whether we transfered the binary correctly |
We always do a space after a #
. Keep it neat :).
Comment on lines
10
to
11
#Verify whether we transfered the binary correctly | ||
compare-sections |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
#Verify whether we transfered the binary correctly | |
compare-sections | |
# Verify whether we transfered the binary correctly | |
compare-sections |
6a22b3c
to
052df4e
Compare
8e0d83c
to
064ef02
Compare
3a26b8bd Correcetly simulate passed time before first clock edge in verilator (#50) 51239127 Add post fetch step that removes `.git` (#48) ca418fcb Merge pull request #47 from clash-lang/lucas/move-stoptime-ndmreset 27c82690 Move `ndmreset` and `stoptime` from `JtagOut` to `CpuOut` 68886c88 Merge pull request #46 from clash-lang/run-clang-format a32dbc98 Add `clang-format-check` to ci 68ca4d0e Format with `clang-format` 9a676aa6 Add `clang` to nix shell 0d4be0e0 Merge pull request #45 from clash-lang/lucas/bump-jtag-interface 61c7719d Bump GHC versions on Docker images and rebuild 5f9a53c9 Add `.scala-build` to `.gitignore` 2c1ec3a3 Remove `openocd-vexriscv` from `nix` and `docker` deabc085 Switch to `openocd-vexriscv` and use `remote-bitbang` d987e396 Replace `DebugPlugin` with `EmbeddedRiscvJtag` 59298429 Add `nix` derivation for `openocv-riscv` 2dfda13f Add `.metals` to `.gitignore` 554f4af1 Bump scala and spinal version 720e5d44 Add execute permissions to `update-vexriscv.pu` ad6edb75 Merge pull request #44 from clash-lang/lucas/add-docker-readme 636ac968 Extend readme with CI info ac10433d Bump GHA actions (#43) 59215117 Merge pull request #42 from clash-lang/add-all-check e697bfdd Fix typo: ouput -> output e7e8e29c Add all check to CI git-subtree-dir: clash-vexriscv git-subtree-split: 3a26b8bdd1a1863030b89943d4bf229c2ce97831
29087a6
to
47f0d50
Compare
`clash-vexriscv` now uses the official EmbeddedJtag plugin and `openocd-riscv` instead of `openocd-vexriscv`
New image contains `openocd-riscv`
These are not used anymore
47f0d50
to
c096da6
Compare
Compiler tuple is not part of the architecture
this makes the code more re-usable and robust by reducing the number of harcoded strings.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
compare-sections
verifies that the sections on the target and local are the same.Depends on #701