firmware ELF loader now handles bigger memsz properly #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vmchale
approved these changes
May 3, 2022
lmbollen
added a commit
that referenced
this pull request
Feb 19, 2025
da3b01a2 Set cache path to Cabal store set in `shell.nix` (#65) 3f9758a1 Check whether Nix shell works on CI (#61) 9363f8d4 Merge pull request #63 from clash-lang/improve-expect-functions 79c5e34a Add timeout to expect functions ed39928d Add call stack to `waitForLine` f1d76ead Use `tail` instead of `streaming` to follow files (#64) e86580bf Remove enable from `cpu` (#58) c69899c2 Drop register on wishbone bus (#59) 1715fc73 Print `JTAG bridge ready` and wait for it to prevent race conditions (#57) 1ca5a69d Merge pull request #53 from clash-lang/add-fourmolu 5e11a6f6 Add `.git-blame-ignore-revs` 2bd141e6 Add fourmolu formatting 96ad7244 Use `HasCallStack` instead of manual source line tracking (#52) 3900cb07 Bump OpenOCD (#54) 3a26b8bd Correcetly simulate passed time before first clock edge in verilator (#50) 51239127 Add post fetch step that removes `.git` (#48) ca418fcb Merge pull request #47 from clash-lang/lucas/move-stoptime-ndmreset 27c82690 Move `ndmreset` and `stoptime` from `JtagOut` to `CpuOut` 68886c88 Merge pull request #46 from clash-lang/run-clang-format a32dbc98 Add `clang-format-check` to ci 68ca4d0e Format with `clang-format` 9a676aa6 Add `clang` to nix shell 0d4be0e0 Merge pull request #45 from clash-lang/lucas/bump-jtag-interface 61c7719d Bump GHC versions on Docker images and rebuild 5f9a53c9 Add `.scala-build` to `.gitignore` 2c1ec3a3 Remove `openocd-vexriscv` from `nix` and `docker` deabc085 Switch to `openocd-vexriscv` and use `remote-bitbang` d987e396 Replace `DebugPlugin` with `EmbeddedRiscvJtag` 59298429 Add `nix` derivation for `openocv-riscv` 2dfda13f Add `.metals` to `.gitignore` 554f4af1 Bump scala and spinal version 720e5d44 Add execute permissions to `update-vexriscv.pu` ad6edb75 Merge pull request #44 from clash-lang/lucas/add-docker-readme 636ac968 Extend readme with CI info ac10433d Bump GHA actions (#43) 59215117 Merge pull request #42 from clash-lang/add-all-check e697bfdd Fix typo: ouput -> output e7e8e29c Add all check to CI git-subtree-dir: clash-vexriscv git-subtree-split: da3b01a2fc91f55cec7fa33c1f07f88631d02ecf
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ELF loader did not inspect the
memszattribute of Program/Segment headers and only loaded the given data from the ELF file (with lengthfilesz).The expected behaviour is to fill remaining bytes (
memsz - filesz) with0. The loader was changed to implement this behaviour and the prop-tests were modified to test for this properly.