Fix bugs in SearchComboBox (improve autocomplete) #3124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bisq's SearchComboBox implements a simple autocomplete. It is used on the "add new altcoin account" form. This fixes the following bugs in the SearchComboBox: * no more dropdown flickering (fixed hide+show hack) * space key no longer resets the text input * unconfirmed changes no longer affect the form * empty list no longer renders empty dropdown This is a preparation step for using SearchComboBox more widely in the project.
ripcurlx
approved these changes
Aug 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bisq's
SearchComboBoximplements a simple autocomplete. It is used on the "add new altcoin account" form.This fixes the following bugs in the
SearchComboBox:This PR is the first step towards using autocomplete more widely in the project. Once merged I will attempt to address #2712 (but can't promise anything).