Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow text input in all currency drop downs #2712

Closed
huey735 opened this issue Apr 15, 2019 · 7 comments
Closed

Allow text input in all currency drop downs #2712

huey735 opened this issue Apr 15, 2019 · 7 comments
Labels
in:gui was:dropped

Comments

@huey735
Copy link
Contributor

huey735 commented Apr 15, 2019

Right now, only when creating a new altcoin account one is able to type the name of the currency to select it from the long drop down options. This option should be expanded to other drop down currency menus in the software.
@ripcurlx
Copy link
Contributor

Yes, we could have a look where else it makes sense to add this functionality.

@ManfredKarrer
Copy link
Contributor

ManfredKarrer commented Apr 17, 2019 •
edited
Loading

Yes that would be definitely good to have at all currency drop downs. We have the code in tha altcoin account setup.

@shamoons
Copy link

I'll take a look and start working on this

@battleofwizards battleofwizards mentioned this issue Aug 21, 2019
Merged
battleofwizards added a commit to battleofwizards/bisq that referenced this issue Aug 25, 2019
@battleofwizards
Add dropdown autocomplete on Market, Buy, Sell tabs; fix bisq-network…
57aa8b5 
…#2226

Basic autocomplete feature for all dropdowns on the major tabs:

* Market / Offer Book
* Market / Trades
* Buy BTC
* Sell BTC

Known limitations:

* Autocomplete still missing from Settings, Account, DAO tabs
* Minor UX glitches remain despite lots of debugging and polishing

Related issues:

* bisq-network#2226 (fixed)
* bisq-network#2712 (partially addressed)
* bisq-network#112 (superseded)
@battleofwizards battleofwizards mentioned this issue Aug 25, 2019
Merged
battleofwizards added a commit to battleofwizards/bisq that referenced this issue Aug 25, 2019
@battleofwizards
Add dropdown autocomplete on Market, Buy, Sell tabs; fix bisq-network…
6520c7f 
…#2226

Basic autocomplete feature for all dropdowns on the major tabs:

* Market / Offer Book
* Market / Trades
* Buy BTC
* Sell BTC

Known limitations:

* Autocomplete still missing from Settings, Account, DAO tabs
* Minor UX glitches remain despite lots of debugging and polishing

Related issues:

* bisq-network#2226 (fixed)
* bisq-network#2712 (partially addressed)
* bisq-network#112 (superseded)
battleofwizards added a commit to battleofwizards/bisq that referenced this issue Aug 25, 2019
@battleofwizards
Add dropdown autocomplete on Market, Buy, Sell tabs; fix bisq-network…
bf51533 
…#2226

Basic autocomplete feature for all dropdowns on the major tabs:

* Market / Offer Book
* Market / Trades
* Buy BTC
* Sell BTC

Known limitations:

* Autocomplete still missing from Settings, Account, DAO tabs
* Minor UX glitches remain despite lots of debugging and polishing

Related issues:

* bisq-network#2226 (fixed)
* bisq-network#2712 (partially addressed)
* bisq-network#112 (superseded)
battleofwizards added a commit to battleofwizards/bisq that referenced this issue Aug 29, 2019
@battleofwizards
Add dropdown autocomplete on Market, Buy, Sell tabs; fix bisq-network…
678b4fe 
…#2226

Basic autocomplete feature for all dropdowns on the major tabs:

* Market / Offer Book
* Market / Trades
* Buy BTC
* Sell BTC

Known limitations:

* Autocomplete still missing from Settings, Account, DAO tabs
* Minor UX glitches remain despite lots of debugging and polishing

Related issues:

* bisq-network#2226 (fixed)
* bisq-network#2712 (partially addressed)
* bisq-network#112 (superseded)
battleofwizards added a commit to battleofwizards/bisq that referenced this issue Aug 29, 2019
@battleofwizards
Add dropdown autocomplete on Market, Buy, Sell tabs; fix bisq-network…
d8d87bb 
…#2226

Basic autocomplete feature for all dropdowns on the major tabs:

* Market / Offer Book
* Market / Trades
* Buy BTC
* Sell BTC

Known limitations:

* Autocomplete still missing from Settings, Account, DAO tabs
* Minor UX glitches remain despite lots of debugging and polishing

Related issues:

* fix bisq-network#2226
* partially addressed bisq-network#2712
* superseded bisq-network#112
battleofwizards added a commit to battleofwizards/bisq that referenced this issue Aug 29, 2019
@battleofwizards
Add dropdown autocomplete on Market, Buy, Sell tabs; fix bisq-network…
9b8bdb3 
…#2226

Basic autocomplete feature for all dropdowns on the major tabs:

* Market / Offer Book
* Market / Trades
* Buy BTC
* Sell BTC

Known limitations:

* Autocomplete still missing from Settings, Account, DAO tabs
* Minor UX glitches remain despite lots of debugging and polishing

Related issues:

* fix bisq-network#2226
* partially addressed bisq-network#2712
* superseded bisq-network#112
battleofwizards added a commit to battleofwizards/bisq that referenced this issue Aug 29, 2019
@battleofwizards
Add dropdown autocomplete on Market, Buy, Sell tabs; fix bisq-network…
3f1b188 
…#2226

Basic autocomplete feature for all dropdowns on the major tabs:

* Market / Offer Book
* Market / Trades
* Buy BTC
* Sell BTC

Known limitations:

* Autocomplete still missing from Settings, Account, DAO tabs
* Minor UX glitches remain despite lots of debugging and polishing

Related issues:

* fix bisq-network#2226
* partially addressed bisq-network#2712
* superseded bisq-network#112
@huey735
Copy link
Contributor Author

huey735 commented Sep 18, 2019

@shamoons @battleofwizards @ripcurlx
This function has been added to the all the Market dropdown menus except for the Settings > Preferences.

@battleofwizards
Copy link
Contributor

battleofwizards commented Sep 18, 2019 •
edited
Loading

@huey735 yes, that is correct.

The first PR only introduced autocomplete on major tabs to limit the volume of changes.

I intend to apply autocomplete more widely in the application over the coming weeks.

@stale
Copy link

stale bot commented Dec 17, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the was:dropped label Dec 17, 2019
@stale
Copy link

stale bot commented Dec 24, 2019

This issue has been automatically closed because of inactivity. Feel free to reopen it if you think it is still relevant.

@stale stale bot closed this as completed Dec 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
in:gui was:dropped
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@ripcurlx @shamoons @ManfredKarrer @huey735 @battleofwizards