Russian lang

[FKrauss]

@y3v63n and I went through the preview version page by page and made a bunch of fixes in both the code and transifex.

We believe it is ready to be merged

Comments and suggestions are welcome!

с новым годом!

[m52go]

Guys, lots of blatant issues here. See preview:
https://deploy-preview-319--bisq-website.netlify.com/ru/

Was this tested beforehand? Or am I missing something? I ran locally with similar results.

Also, a nit: please stick with convention of lower-case language codes -- /ru not /RU.

[FKrauss]

I tested locally and it was working fine on my mac, but not on Evgeny's

[FKrauss]

I guess I now have a plan for Monday night :)

[FKrauss]

hey, i tried fiddling with the files to find a comma that was missing or something but didn't really find anything. It literally "works on my machine" but not in the preview:

could we try deploying this to the live page to see if it is a config issue on the preview?

[m52go]

Netlify itself isn't able to build the page correctly...see for yourself:
https://deploy-preview-319--bisq-website.netlify.com/ru/

That means the live site won't build correctly either. The root issue here needs to be figured out.

[FKrauss]

I see it. I found this: https://stackoverflow.com/questions/53958771/i-can-serve-my-jekyll-site-locally-but-cant-get-it-working-on-netlify I'll take a look at it when I have time (I believe tomorrow night). Do you know if the preview redeploys on every new commit (so if I test something I can tell whether or not it worked)?

…

On Wed, 15 Jan 2020 at 10:33, Steve Jain ***@***.***> wrote: Netlify itself isn't able to build the page correctly...see for yourself: https://deploy-preview-319--bisq-website.netlify.com/ru/ That means the live site won't build correctly either. The root issue here needs to be figured out. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#319?email_source=notifications&email_token=ABEY5S6THZDQZDCMU2PX5XTQ53J7VA5CNFSM4J66DPF2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEI7U7CA#issuecomment-574574472>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABEY5S6ZQL4HDXVK252BZQDQ53J7VANCNFSM4J66DPFQ> .

-- *Fábio Krauss Stabel* +45 93 93 21 31 PGP keys <https://keys.mailvelope.com/pks/lookup?op=get&search=0xE5058064B3E7342F>

[m52go]

Yes, it redeploys on every commit. But FYI it's not working locally on my machine either.

[FKrauss]

What is the error that Jekyll gives you?

…

On Wed, 15 Jan 2020 at 10:56, Steve Jain ***@***.***> wrote: Yes, it redeploys on every commit. But FYI it's not working locally on my machine either. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#319?email_source=notifications&email_token=ABEY5SZVZHRH3KWXXBRE6KLQ53MVBA5CNFSM4J66DPF2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEI7XINI#issuecomment-574583861>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABEY5S3E4WCBXQNT6PMGXXTQ53MVBANCNFSM4J66DPFQ> .

-- *Fábio Krauss Stabel* +45 93 93 21 31 PGP keys <https://keys.mailvelope.com/pks/lookup?op=get&search=0xE5058064B3E7342F>

[huey735]

Hi @FKrauss @m52go. I have yet to wrap my head around Netlify but I think I got it working here: https://5e29c0f063bd1e8a6520873e--huey.netlify.com/ru/

There's a discrepancy in @FKrauss file naming. Some places it's "ru" and others is "RU". Renaming the language root folder and the .yml folder inside ./_data to "ru" did the trick for me.

[FKrauss]

Cool! Let's try that. I'll also add it to the tutorial file

…

On Thu, 23 Jan 2020, 16:59 huey735, ***@***.***> wrote: Hi @FKrauss <https://github.com/FKrauss> @m52go <https://github.com/m52go>. I have yet to wrap my head around Netlify but I think I got it working here: https://5e29c0f063bd1e8a6520873e--huey.netlify.com/ru/ There's a discrepancy in @FKrauss <https://github.com/FKrauss> file naming. Some places it's "ru" and others is "RU". Renaming the language root folder and the .yml folder inside ./_data to "ru" did the trick for me. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#319?email_source=notifications&email_token=ABEY5S2LZ36VLPEYAP5QNPTQ7G5FDA5CNFSM4J66DPF2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEJX3F5Y#issuecomment-577745655>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABEY5S253P3VTAY5CRZIT73Q7G5FDANCNFSM4J66DPFQ> .

[FKrauss]

yeap, worked

[FKrauss]

awesome! @huey735 great catch!

@y3v63n, please take a look at it

[FKrauss]

I guess once we give the green light to this one, @y3v63n and I can work on translating the image SVGs

[FKrauss]

Hi @FKrauss @m52go. I have yet to wrap my head around Netlify but I think I got it working here: https://5e29c0f063bd1e8a6520873e--huey.netlify.com/ru/

There's a discrepancy in @FKrauss file naming. Some places it's "ru" and others is "RU". Renaming the language root folder and the .yml folder inside ./_data to "ru" did the trick for me.

This is what was different in my local repo and the one on github, I couldn't get Github to take my lower case folders/filenames unless I would rename them to something else and then to lowercase (see commits 12b1416 and 4706c7a).

[m52go]

Are you going to do localized screenshots for the front page? (Is the Bisq software available in Russian?)

In any case, please update the images on DAO page.

Otherwise looking forward to feedback from @y3v63n.

[FKrauss]

yes but I believe that should be done in a separate PR. and we should take this as an opportunity to document the process

…

On Mon, 27 Jan 2020 at 07:21, Steve Jain ***@***.***> wrote: ***@***.**** commented on this pull request. Are you going to do localized screenshots for the front page? (Is the Bisq software available in Russian?) In any case, please update the images on DAO page. Otherwise looking forward to feedback from @y3v63n <https://github.com/y3v63n>. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#319?email_source=notifications&email_token=ABEY5S6F5L65ORGTMR2S42DQ7Z4PFA5CNFSM4J66DPF2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCTCP4IA#pullrequestreview-348454432>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABEY5SYJESUFYGWNFELVTY3Q7Z4PFANCNFSM4J66DPFQ> .

-- *Fábio Krauss Stabel* +45 93 93 21 31 PGP keys <https://keys.mailvelope.com/pks/lookup?op=get&search=0xE5058064B3E7342F>

[m52go]

Images are part of the translation, no? I think they fit into this one.

[FKrauss]

They are, but not all languages have them translated. As one also needs to translate currency values to the local one. Additionally having a website in your language can help you get started even when the images are in English. My humble opinion is that translated images are icing on the cake. Nice to have, but not required to launch.

…

On Mon, 27 Jan 2020 at 09:31, Steve Jain ***@***.***> wrote: Images are part of the translation, no? I think they fit into this one. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#319?email_source=notifications&email_token=ABEY5SYZML4QRF3JX2IM263Q72LUXA5CNFSM4J66DPF2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEJ6V7VQ#issuecomment-578641878>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABEY5S5D4CC4TYXXQPBLCQTQ72LUXANCNFSM4J66DPFQ> .

-- *Fábio Krauss Stabel* +45 93 93 21 31 PGP keys <https://keys.mailvelope.com/pks/lookup?op=get&search=0xE5058064B3E7342F>

[FKrauss]

also, if he doesn't show up, I can have other Russian friends I know take a look at and proofread it

[Nadumanov]

The translation is decent and the pages are good to go.